Skip to content

Change public API to better adapt to C#/.NET conventions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siwatanejo wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change public API to better adapt to C#/.NET conventions #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
199385b
Nuget version bump
siwatanejo Mar 15, 2024
98fa9ed
[C#] Use `I` prefix for interfaces
Mersho Mar 4, 2024
7dda68f
[C#] Change all method names to PascalCase
Mersho Mar 15, 2024
f0625cd
Re-generate C# bindings using updated script
webwarrior-ws Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Continuous Integration Checks
on: [push, pull_request]

env:
NUGET_PACKAGE_VERSION: 0.0.0.5
NUGET_PACKAGE_VERSION: 0.0.0.6

jobs:
wasm_bindings:
Expand Down
14,226 changes: 7,113 additions & 7,113 deletions c_sharp/src/org/ldk/impl/bindings.cs
View file
Open in desktop

Large diffs are not rendered by default.

46 changes: 23 additions & 23 deletions c_sharp/src/org/ldk/structs/APIError.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ namespace org { namespace ldk { namespace structs {
public class APIError : CommonBase {
protected APIError(object _dummy, long ptr) : base(ptr) { }
~APIError() {
if (ptr != 0) { bindings.APIError_free(ptr); }
if (ptr != 0) { Bindings.APIErrorFree(ptr); }
}

internal static APIError constr_from_ptr(long ptr) {
long raw_ty = bindings.LDKAPIError_ty_from_ptr(ptr);
long raw_ty = Bindings.LDKAPIErrorTyFromPtr(ptr);
switch (raw_ty) {
case 0: return new APIError_APIMisuseError(ptr);
case 1: return new APIError_FeeRateTooHigh(ptr);
Expand All @@ -36,8 +36,8 @@ public class APIError_APIMisuseError : APIError {
*/
public string err;
internal APIError_APIMisuseError(long ptr) : base(null, ptr) {
long err = bindings.LDKAPIError_APIMisuseError_get_err(ptr);
string err_conv = InternalUtils.decodeString(err);
long err = Bindings.LDKAPIErrorAPIMisuseErrorGetErr(ptr);
string err_conv = InternalUtils.DecodeString(err);
this.err = err_conv;
}
}
Expand All @@ -52,10 +52,10 @@ public class APIError_FeeRateTooHigh : APIError {
*/
public int feerate;
internal APIError_FeeRateTooHigh(long ptr) : base(null, ptr) {
long err = bindings.LDKAPIError_FeeRateTooHigh_get_err(ptr);
string err_conv = InternalUtils.decodeString(err);
long err = Bindings.LDKAPIErrorFeeRateTooHighGetErr(ptr);
string err_conv = InternalUtils.DecodeString(err);
this.err = err_conv;
this.feerate = bindings.LDKAPIError_FeeRateTooHigh_get_feerate(ptr);
this.feerate = Bindings.LDKAPIErrorFeeRateTooHighGetFeerate(ptr);
}
}
/** A APIError of type InvalidRoute */
Expand All @@ -65,8 +65,8 @@ public class APIError_InvalidRoute : APIError {
*/
public string err;
internal APIError_InvalidRoute(long ptr) : base(null, ptr) {
long err = bindings.LDKAPIError_InvalidRoute_get_err(ptr);
string err_conv = InternalUtils.decodeString(err);
long err = Bindings.LDKAPIErrorInvalidRouteGetErr(ptr);
string err_conv = InternalUtils.DecodeString(err);
this.err = err_conv;
}
}
Expand All @@ -77,8 +77,8 @@ public class APIError_ChannelUnavailable : APIError {
*/
public string err;
internal APIError_ChannelUnavailable(long ptr) : base(null, ptr) {
long err = bindings.LDKAPIError_ChannelUnavailable_get_err(ptr);
string err_conv = InternalUtils.decodeString(err);
long err = Bindings.LDKAPIErrorChannelUnavailableGetErr(ptr);
string err_conv = InternalUtils.DecodeString(err);
this.err = err_conv;
}
}
Expand All @@ -94,14 +94,14 @@ public class APIError_IncompatibleShutdownScript : APIError {
*/
public ShutdownScript script;
internal APIError_IncompatibleShutdownScript(long ptr) : base(null, ptr) {
long script = bindings.LDKAPIError_IncompatibleShutdownScript_get_script(ptr);
long script = Bindings.LDKAPIErrorIncompatibleShutdownScriptGetScript(ptr);
org.ldk.structs.ShutdownScript script_hu_conv = null; if (script < 0 || script > 4096) { script_hu_conv = new org.ldk.structs.ShutdownScript(null, script); }
if (script_hu_conv != null) { script_hu_conv.ptrs_to.AddLast(this); };
this.script = script_hu_conv;
}
}
internal long clone_ptr() {
long ret = bindings.APIError_clone_ptr(this.ptr);
long ret = Bindings.APIErrorClonePtr(this.ptr);
GC.KeepAlive(this);
return ret;
}
Expand All @@ -110,7 +110,7 @@ internal long clone_ptr() {
* Creates a copy of the APIError
*/
public APIError clone() {
long ret = bindings.APIError_clone(this.ptr);
long ret = Bindings.APIErrorClone(this.ptr);
GC.KeepAlive(this);
if (ret >= 0 && ret <= 4096) { return null; }
org.ldk.structs.APIError ret_hu_conv = org.ldk.structs.APIError.constr_from_ptr(ret);
Expand All @@ -122,7 +122,7 @@ public APIError clone() {
* Utility method to constructs a new APIMisuseError-variant APIError
*/
public static APIError apimisuse_error(string err) {
long ret = bindings.APIError_apimisuse_error(InternalUtils.encodeString(err));
long ret = Bindings.APIErrorApimisuseError(InternalUtils.EncodeString(err));
GC.KeepAlive(err);
if (ret >= 0 && ret <= 4096) { return null; }
org.ldk.structs.APIError ret_hu_conv = org.ldk.structs.APIError.constr_from_ptr(ret);
Expand All @@ -134,7 +134,7 @@ public static APIError apimisuse_error(string err) {
* Utility method to constructs a new FeeRateTooHigh-variant APIError
*/
public static APIError fee_rate_too_high(string err, int feerate) {
long ret = bindings.APIError_fee_rate_too_high(InternalUtils.encodeString(err), feerate);
long ret = Bindings.APIErrorFeeRateTooHigh(InternalUtils.EncodeString(err), feerate);
GC.KeepAlive(err);
GC.KeepAlive(feerate);
if (ret >= 0 && ret <= 4096) { return null; }
Expand All @@ -147,7 +147,7 @@ public static APIError fee_rate_too_high(string err, int feerate) {
* Utility method to constructs a new InvalidRoute-variant APIError
*/
public static APIError invalid_route(string err) {
long ret = bindings.APIError_invalid_route(InternalUtils.encodeString(err));
long ret = Bindings.APIErrorInvalidRoute(InternalUtils.EncodeString(err));
GC.KeepAlive(err);
if (ret >= 0 && ret <= 4096) { return null; }
org.ldk.structs.APIError ret_hu_conv = org.ldk.structs.APIError.constr_from_ptr(ret);
Expand All @@ -159,7 +159,7 @@ public static APIError invalid_route(string err) {
* Utility method to constructs a new ChannelUnavailable-variant APIError
*/
public static APIError channel_unavailable(string err) {
long ret = bindings.APIError_channel_unavailable(InternalUtils.encodeString(err));
long ret = Bindings.APIErrorChannelUnavailable(InternalUtils.EncodeString(err));
GC.KeepAlive(err);
if (ret >= 0 && ret <= 4096) { return null; }
org.ldk.structs.APIError ret_hu_conv = org.ldk.structs.APIError.constr_from_ptr(ret);
Expand All @@ -171,7 +171,7 @@ public static APIError channel_unavailable(string err) {
* Utility method to constructs a new MonitorUpdateInProgress-variant APIError
*/
public static APIError monitor_update_in_progress() {
long ret = bindings.APIError_monitor_update_in_progress();
long ret = Bindings.APIErrorMonitorUpdateInProgress();
if (ret >= 0 && ret <= 4096) { return null; }
org.ldk.structs.APIError ret_hu_conv = org.ldk.structs.APIError.constr_from_ptr(ret);
if (ret_hu_conv != null) { ret_hu_conv.ptrs_to.AddLast(ret_hu_conv); };
Expand All @@ -182,7 +182,7 @@ public static APIError monitor_update_in_progress() {
* Utility method to constructs a new IncompatibleShutdownScript-variant APIError
*/
public static APIError incompatible_shutdown_script(org.ldk.structs.ShutdownScript script) {
long ret = bindings.APIError_incompatible_shutdown_script(script == null ? 0 : script.ptr);
long ret = Bindings.APIErrorIncompatibleShutdownScript(script == null ? 0 : script.ptr);
GC.KeepAlive(script);
if (ret >= 0 && ret <= 4096) { return null; }
org.ldk.structs.APIError ret_hu_conv = org.ldk.structs.APIError.constr_from_ptr(ret);
Expand All @@ -196,7 +196,7 @@ public static APIError incompatible_shutdown_script(org.ldk.structs.ShutdownScri
* This ignores pointers and is_owned flags and looks at the values in fields.
*/
public bool eq(org.ldk.structs.APIError b) {
bool ret = bindings.APIError_eq(this.ptr, b == null ? 0 : b.ptr);
bool ret = Bindings.APIErrorEq(this.ptr, b == null ? 0 : b.ptr);
GC.KeepAlive(this);
GC.KeepAlive(b);
return ret;
Expand All @@ -210,10 +210,10 @@ public override bool Equals(object o) {
* Serialize the APIError object into a byte array which can be read by APIError_read
*/
public byte[] write() {
long ret = bindings.APIError_write(this.ptr);
long ret = Bindings.APIErrorWrite(this.ptr);
GC.KeepAlive(this);
if (ret >= 0 && ret <= 4096) { return null; }
byte[] ret_conv = InternalUtils.decodeUint8Array(ret);
byte[] ret_conv = InternalUtils.DecodeUint8Array(ret);
return ret_conv;
}

Expand Down
Loading