Change public API to better adapt to C#/.NET conventions#4
Change public API to better adapt to C#/.NET conventions#4siwatanejo wants to merge 4 commits intopackwallet:mainfrom
Conversation
We change all interfaces to PascalCase in C# to comply with the C# coding style and the C# code conventions as outlined by Microsoft [1]: - "Interface names start with a capital I." [1] https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names
We change all method and class names to PascalCase in C# to comply with the C# coding style and the C# code conventions as outlined by Microsoft [1]: - "Use PascalCase for class names and method names." [1] https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/identifier-names
|
You should build the project and update the generated files in the same PR. |
What do you mean? You're saying the generated nuget package does not actually have the new API? |
The code that this script generates is also commited (it's not in the gitignore) so you need to build the project so new files get generated and you should the put the new generated files in this PR |
Do I understand correctly, that I have to follow CI steps on Debian or Fedora? |
|
I don't think what Afshin said is related to CI at all? I mean, if it's just about running a script and the result generates API changes, maybe it works just running it in Ubuntu as well. I'll let Afshin reply anyway |
4 participants
Supersedes #1