Fix label caching for PRs with no labels

[lbarcziova]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @lbarcziova, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a caching bug in the label retrieval mechanism for pull requests. Previously, PRs without any labels would cause the label list to be repeatedly re-fetched due to an incorrect caching check. The fix ensures that an empty list of labels is properly cached, optimizing performance and preventing redundant API calls for such pull requests.

Highlights

• Label Caching Logic: Modified the caching condition for pull request labels in both Forgejo and GitHub service implementations. The condition if not self._labels: was changed to if self._labels is None: to correctly handle cases where a pull request has no labels, preventing unnecessary re-fetching.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request modifies the labels property in both ogr/services/forgejo/pull_request.py and ogr/services/github/pull_request.py. The change updates the conditional check for lazy loading the _labels attribute from if not self._labels: to if self._labels is None:. This ensures that the labels are only initialized if the _labels attribute is explicitly None, allowing an empty list of labels to be a valid, already-loaded state without triggering re-initialization.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/9ce59ce2237141539fd0bc303ab11d4e

✔️ pre-commit SUCCESS in 3m 06s
✔️ ogr-tests-pip-deps SUCCESS in 17m 50s