Skip to content

Use 16-channel virtual mux on Cosmo #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025
Merged

Use 16-channel virtual mux on Cosmo #2154

merged 3 commits into from
Jul 22, 2025

Conversation

mkeeter
Copy link
Collaborator

@mkeeter mkeeter commented Jul 16, 2025

Right now, the Cosmo FPGAs (main and front) both pretend to contain a set of PCA9545 muxes. This PR switches to a single virtual 16-channel mux, which reduces writes (since we no longer need to deactivate virtual mux N before activating virtual mux M).

Having a single mux also makes it more logically consistent to have a single reset pin, see https://github.com/oxidecomputer/hardware-cosmo/issues/619

Finally, it gives us a place to put the delay required by the physical switches' timing that doesn't mess with our existing driver.

So far, this PR only has Hubris changes; FPGA updates to come.

@mkeeter mkeeter requested a review from nathanaelhuffman July 16, 2025 14:33
@mkeeter mkeeter force-pushed the mkeeter/cosmo-mux16 branch 2 times, most recently from 4ac7426 to 7758bc6 Compare July 16, 2025 14:35
@mkeeter mkeeter marked this pull request as draft July 16, 2025 14:35
@mkeeter mkeeter force-pushed the mkeeter/cosmo-mux16 branch from 7758bc6 to 7366163 Compare July 17, 2025 14:46
@mkeeter mkeeter added the cosmo SP5 Board label Jul 17, 2025
@mkeeter mkeeter marked this pull request as ready for review July 21, 2025 21:55
@mkeeter mkeeter force-pushed the mkeeter/cosmo-mux16 branch from 2f78f25 to 4395701 Compare July 22, 2025 13:33
@mkeeter mkeeter requested review from cbiffle, hawkw and labbott July 22, 2025 13:46
Copy link
Contributor

@nathanaelhuffman nathanaelhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works patched on my machine

@mkeeter mkeeter merged commit f85d96e into master Jul 22, 2025
135 checks passed
@mkeeter mkeeter deleted the mkeeter/cosmo-mux16 branch July 22, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmo SP5 Board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants