Skip to content

A11y fix visible labels #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stevefrenzel wants to merge 4 commits into from
Closed

A11y fix visible labels #5969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
693f35e
feat(AppBar): updated tooltip text
Nov 2, 2021
c4572a6
feat(CollaboratorsEditOptions): added aria-label
Nov 2, 2021
8dd0db0
feat(UserMenu): added aria-label
Nov 2, 2021
9eb83db
Update TopBar.spec.js.snap
Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/AppBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export default {
if (tooltip) {
return tooltip
}
return this.$gettext('Add files or folders')
return this.$gettext('Add new files or folders')
},
currentPath() {
const path = this.$route.params.item || ''
Expand Down
9 changes: 7 additions & 2 deletions packages/web-app-files/src/components/Collaborators/CollaboratorsEditOptions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
<template>
<div>
<translate tag="label" for="files-collaborators-role-button" class="oc-label">Role</translate>
<translate
:aria-label="$gettext('Role')"
tag="label"
for="files-collaborators-role-button"
class="oc-label"
>Role</translate
Copy link
Copy Markdown
Contributor

@pascalwengerter pascalwengerter Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run yarn lint in the project please? The linter failed in CI, this command should show you what needs to be changed (and you can yarn lint --fix to fix it)

>
<oc-select
v-model="selectedRole"
input-id="files-collaborators-role-button"
class="files-collaborators-role-button-wrapper"
:options="roles"
:clearable="false"
label="label"
Copy link
Copy Markdown
Contributor

@pascalwengerter pascalwengerter Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On owncloud/owncloud-design-system#1530 we have changed the way labels work for the OcSelect component so you should be able to remove the span above and pass a computed property in the label line you deleted (see owncloud/owncloud-design-system@088159b)

>
<template v-slot:option="option">
<role-item :role="option" />
Expand Down
8 changes: 6 additions & 2 deletions packages/web-runtime/src/components/UserMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
class="oc-topbar-personal uk-height-1-1 oc-pr-xs"
appearance="raw"
variation="passive"
:aria-label="$gettext('User Menu')"
:aria-label="userDisplayName"
>
<oc-grid flex>
<avatar-image
Expand All @@ -15,7 +15,11 @@
:userid="userId"
:user-name="userDisplayName"
/>
<div class="oc-topbar-personal-label oc-text-bold oc-ml-rm" v-text="userDisplayName" />
<div
class="oc-topbar-personal-label oc-text-bold oc-ml-rm"
:aria-label="userDisplayName"
v-text="userDisplayName"
/>
</oc-grid>
</oc-button>
<oc-drop
Expand Down
10 changes: 5 additions & 5 deletions packages/web-runtime/tests/components/__snapshots__/TopBar.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`Top Bar component Displays applications menu 1`] = `
<header aria-label="Top bar" class="oc-topbar uk-flex uk-flex-middle uk-flex-wrap oc-border-b oc-p-s">
<oc-grid-stub gutter="medium" flex="">
<div class="uk-hidden@l">
<oc-button-stub appearance="raw" aria-label="Open navigation menu" class="oc-app-navigation-toggle">
<oc-button-stub appearance="raw" aria-label="Toggle application navigation menu" class="oc-app-navigation-toggle">
<oc-icon-stub name="menu"></oc-icon-stub>
</oc-button-stub>
</div>
Expand All @@ -22,7 +22,7 @@ exports[`Top Bar component when search bar hidden globally Hides search bar even
<header aria-label="Top bar" class="oc-topbar uk-flex uk-flex-middle uk-flex-wrap oc-border-b oc-p-s">
<oc-grid-stub gutter="medium" flex="">
<div class="uk-hidden@l">
<oc-button-stub appearance="raw" aria-label="Open navigation menu" class="oc-app-navigation-toggle">
<oc-button-stub appearance="raw" aria-label="Toggle application navigation menu" class="oc-app-navigation-toggle">
<oc-icon-stub name="menu"></oc-icon-stub>
</oc-button-stub>
</div>
Expand All @@ -40,7 +40,7 @@ exports[`Top Bar component when search bar hidden globally Hides the search bar
<header aria-label="Top bar" class="oc-topbar uk-flex uk-flex-middle uk-flex-wrap oc-border-b oc-p-s">
<oc-grid-stub gutter="medium" flex="">
<div class="uk-hidden@l">
<oc-button-stub appearance="raw" aria-label="Open navigation menu" class="oc-app-navigation-toggle">
<oc-button-stub appearance="raw" aria-label="Toggle application navigation menu" class="oc-app-navigation-toggle">
<oc-icon-stub name="menu"></oc-icon-stub>
</oc-button-stub>
</div>
Expand All @@ -58,7 +58,7 @@ exports[`Top Bar component when search bar visible globally Displays search bar
<header aria-label="Top bar" class="oc-topbar uk-flex uk-flex-middle uk-flex-wrap oc-border-b oc-p-s">
<oc-grid-stub gutter="medium" flex="">
<div class="uk-hidden@l">
<oc-button-stub appearance="raw" aria-label="Open navigation menu" class="oc-app-navigation-toggle">
<oc-button-stub appearance="raw" aria-label="Toggle application navigation menu" class="oc-app-navigation-toggle">
<oc-icon-stub name="menu"></oc-icon-stub>
</oc-button-stub>
</div>
Expand All @@ -76,7 +76,7 @@ exports[`Top Bar component when search bar visible globally Hides the search bar
<header aria-label="Top bar" class="oc-topbar uk-flex uk-flex-middle uk-flex-wrap oc-border-b oc-p-s">
<oc-grid-stub gutter="medium" flex="">
<div class="uk-hidden@l">
<oc-button-stub appearance="raw" aria-label="Open navigation menu" class="oc-app-navigation-toggle">
<oc-button-stub appearance="raw" aria-label="Toggle application navigation menu" class="oc-app-navigation-toggle">
<oc-icon-stub name="menu"></oc-icon-stub>
</oc-button-stub>
</div>
Expand Down