A11y fix visible labels#5969
Closed
stevefrenzel wants to merge 4 commits into
Closed
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
pascalwengerter
requested changes
Nov 15, 2021
| tag="label" | ||
| for="files-collaborators-role-button" | ||
| class="oc-label" | ||
| >Role</translate |
Contributor
There was a problem hiding this comment.
Could you run yarn lint in the project please? The linter failed in CI, this command should show you what needs to be changed (and you can yarn lint --fix to fix it)
| class="files-collaborators-role-button-wrapper" | ||
| :options="roles" | ||
| :clearable="false" | ||
| label="label" |
Contributor
There was a problem hiding this comment.
On owncloud/owncloud-design-system#1530 we have changed the way labels work for the OcSelect component so you should be able to remove the span above and pass a computed property in the label line you deleted (see owncloud/owncloud-design-system@088159b)
Contributor
|
Closing this as outdated, will provide a fix directly on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated aria-labels to pass accessibility requirements.
Related Issue
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: