Skip to content

Conversation

@TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Dec 8, 2025

See #77 , implemented it in a non-breaking way, so we can still use it fine with Credo 0.6

@TimoGlastra TimoGlastra requested a review from a team as a code owner December 8, 2025 06:11
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

🦋 Changeset detected

Latest commit: 25ed97f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@openwallet-foundation/askar-react-native Patch
@openwallet-foundation/askar-nodejs Patch
@openwallet-foundation/askar-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TimoGlastra
Copy link
Contributor Author

FYI @bryce-mcmath, I think the same change should be made to the Indy VDR wrapper

@swcurran
Copy link
Contributor

swcurran commented Dec 8, 2025

Why the skipped/required tests? Should that be adjusted? Approved based on @hacdias review :-) .

@TimoGlastra
Copy link
Contributor Author

We skip the pull_request_review, the tests are already covered by pull_request.

Github Actions automatically opens PRs for new versions (e.g. #76), however PRs opened by Github Actions can't trigger a Github Actions workflow (to prevent endless recursion mistakes...). So to trigger the CI on those PR we trigger it based on a review (the pull_request_review). The jobs are marked as required, but it doesn't matter if they were triggered based on pull_request or pull_request_review as long as the job runs. Long explanation for: No, they don't have to be adjusted. 😄

@TimoGlastra TimoGlastra merged commit 9121e2a into main Dec 8, 2025
12 checks passed
@TimoGlastra TimoGlastra deleted the fix/askar-registration branch December 8, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants