fix: askar registration (#78)

Signed-off-by: Timo Glastra <[email protected]>

Author: TimoGlastra

.changeset/wet-comics-love.md

@@ -0,0 +1,11 @@
+---
+"@openwallet-foundation/askar-react-native": patch
+"@openwallet-foundation/askar-nodejs": patch
+"@openwallet-foundation/askar-shared": patch
+---
+
+fix: wrap the askar registration with a `NativeAskar` class that exposes two static members: a `.instance` getter and `register` method.
+
+Previously when you did not import the native askar library on the first line (or above all logic that uses Askar) the reference to Askar would be undefined. (i.e. askar-shared is imported before askar-react-native or askar-nodejs)
+
+The `registerAskar` method and `askar` property are kept for backwards compatibility, but these are still prone to the same error. `registerAskar` integrated with the new `NativeAskar` class, and so all usages within the shared library, as well as the nodejs and react-native wrappers will be fixed. We recommend to update to the new `NativeAskar` class for all other usages.

packages/askar-nodejs/package.json

@@ -28,7 +28,7 @@
   },
   "dependencies": {
     "@openwallet-foundation/askar-shared": "workspace:*",
-    "koffi": "^2.9.0"
+    "koffi": "^2.14.1"
   },
   "devDependencies": {
     "@types/node": "catalog:",

packages/askar-nodejs/src/index.ts

@@ -1,7 +1,7 @@
-import { registerAskar } from '@openwallet-foundation/askar-shared'
+import { NativeAskar } from '@openwallet-foundation/askar-shared'
 import { NodeJSAskar } from './NodeJSAskar'
 
 export const askarNodeJS = new NodeJSAskar()
-registerAskar({ askar: askarNodeJS })
+NativeAskar.register(askarNodeJS)
 
 export * from '@openwallet-foundation/askar-shared'

packages/askar-nodejs/src/library/register.ts

@@ -54,7 +54,7 @@ const getLibrary = () => {
     path.join(p, `${extensions[platform].prefix ?? ''}${LIBNAME}${extensions[platform].extension}`)
   )
 
-  // Gaurd so we quit if there is no valid path for the library
+  // Guard so we quit if there is no valid path for the library
   if (!libraries.some((libraryPath) => doesPathExist(libraryPath)))
     throw new Error(`Could not find ${LIBNAME} with these paths: ${libraries.join(' ')}`)
 

packages/askar-react-native/src/index.ts

@@ -1,4 +1,4 @@
-import { registerAskar } from '@openwallet-foundation/askar-shared'
+import { NativeAskar } from '@openwallet-foundation/askar-shared'
 import { NativeModules } from 'react-native'
 import type { NativeBindings } from './NativeBindings'
 
@@ -17,4 +17,4 @@ if (!_askar) {
 
 declare let _askar: NativeBindings
 
-registerAskar({ askar: new ReactNativeAskar(_askar) })
+NativeAskar.register(new ReactNativeAskar(_askar))

packages/askar-shared/src/askar/register.ts

@@ -1,7 +1,33 @@
+import { AskarError } from '../error'
 import type { Askar } from './Askar'
 
+/**
+ * @deprecated use `NativeAskar.instance` instead
+ */
 export let askar: Askar
 
+export class NativeAskar {
+  static #nativeAskar: Askar | undefined
+
+  public static get instance(): Askar {
+    if (!NativeAskar.#nativeAskar)
+      throw AskarError.customError({
+        message:
+          "Native askar has not been registered yet. Make sure to import '@openwallet-foundation/askar-nodejs' or '@openwallet-foundation/askar-react-native', or call 'NativeAskar.register' with a custom implementation.",
+      })
+
+    return NativeAskar.#nativeAskar
+  }
+
+  public static register(nativeAskar: Askar) {
+    askar = nativeAskar
+    NativeAskar.#nativeAskar = nativeAskar
+  }
+}
+
+/**
+ * @deprecated use `NativeAskar.register` instead
+ */
 export const registerAskar = (options: { askar: Askar }) => {
-  askar = options.askar
+  NativeAskar.register(options.askar)
 }

packages/askar-shared/src/crypto/Argon2.ts

@@ -1,4 +1,4 @@
-import { askar } from '../askar'
+import { NativeAskar } from '../askar'
 
 export enum Argon2Parameters {
   Moderate = 0,
@@ -7,6 +7,6 @@ export enum Argon2Parameters {
 
 export class Argon2 {
   public static derivePassword(parameters: Argon2Parameters, password: Uint8Array, salt: Uint8Array): Uint8Array {
-    return askar.argon2DerivePassword({ parameters, password, salt })
+    return NativeAskar.instance.argon2DerivePassword({ parameters, password, salt })
   }
 }

packages/askar-shared/src/crypto/CryptoBox.ts

@@ -1,9 +1,9 @@
-import { askar } from '../askar'
+import { NativeAskar } from '../askar'
 import type { Key } from './Key'
 
 export class CryptoBox {
   public static randomNonce() {
-    return askar.keyCryptoBoxRandomNonce()
+    return NativeAskar.instance.keyCryptoBoxRandomNonce()
   }
 
   public static cryptoBox({
@@ -17,7 +17,7 @@ export class CryptoBox {
     message: Uint8Array
     nonce: Uint8Array
   }) {
-    return askar.keyCryptoBox({ nonce, message, senderKey, recipientKey })
+    return NativeAskar.instance.keyCryptoBox({ nonce, message, senderKey, recipientKey })
   }
 
   public static open({
@@ -31,14 +31,14 @@ export class CryptoBox {
     message: Uint8Array
     nonce: Uint8Array
   }) {
-    return askar.keyCryptoBoxOpen({ nonce, message, senderKey, recipientKey })
+    return NativeAskar.instance.keyCryptoBoxOpen({ nonce, message, senderKey, recipientKey })
   }
 
   public static seal({ recipientKey, message }: { recipientKey: Key; message: Uint8Array }) {
-    return askar.keyCryptoBoxSeal({ message, localKeyHandle: recipientKey.handle })
+    return NativeAskar.instance.keyCryptoBoxSeal({ message, localKeyHandle: recipientKey.handle })
   }
 
   public static sealOpen({ recipientKey, ciphertext }: { recipientKey: Key; ciphertext: Uint8Array }) {
-    return askar.keyCryptoBoxSealOpen({ ciphertext, localKeyHandle: recipientKey.handle })
+    return NativeAskar.instance.keyCryptoBoxSealOpen({ ciphertext, localKeyHandle: recipientKey.handle })
   }
 }

packages/askar-shared/src/crypto/Ecdh1PU.ts

@@ -1,4 +1,4 @@
-import { askar } from '../askar'
+import { NativeAskar } from '../askar'
 import type { KeyAlgorithm } from '../enums'
 import { Key } from './Key'
 
@@ -29,7 +29,7 @@ export class Ecdh1PU {
     ccTag?: Uint8Array
   }): Key {
     return new Key(
-      askar.keyDeriveEcdh1pu({
+      NativeAskar.instance.keyDeriveEcdh1pu({
         algId: this.algId,
         receive,
         apv: this.apv,

packages/askar-shared/src/crypto/EcdhEs.ts

@@ -1,4 +1,4 @@
-import { askar } from '../askar'
+import { askar, NativeAskar } from '../askar'
 import type { KeyAlgorithm } from '../enums'
 
 import { Jwk } from './Jwk'
@@ -27,7 +27,7 @@ export class EcdhEs {
     receive: boolean
   }): Key {
     return new Key(
-      askar.keyDeriveEcdhEs({
+      NativeAskar.instance.keyDeriveEcdhEs({
         algId: this.algId,
         receive,
         apv: this.apv,