Move from SDL_Surface* to abstract RGBA storage class #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested, incomplete. This was the idea: > Across the codebase, move from SDLSurface* as storage for RGBA data to an abstract RGBA storage class which can be subclassed to either contain an SDLSurface or an OpenGL texture, while also containing the RGBA data. Move Sprite* and other classes to use that. --- Update the codebase to use an abstract RGBA storage class instead of SDL_Surface* for RGBA data storage. * Add `rgba_storage.h` to define an abstract class `RGBAStorage` with subclasses `SDLSurfaceStorage` and `OpenGLTextureStorage`. * Modify `sprite.h` and `sprite.cpp` to replace `SDL_Surface*` with `std::shared_ptr<RGBAStorage>` and update methods accordingly. * Modify `spritesdl.cpp` to use `RGBAStorage` methods for accessing RGBA data. * Modify `spritegl.h` and `spritegl.cpp` to use `std::shared_ptr<RGBAStorage>` for RGBA data storage. * Modify `automap.cpp` to use `std::shared_ptr<RGBAStorage>` for RGBA data storage. * Modify `engine.cpp` to use `std::shared_ptr<RGBAStorage>` for RGBA data storage. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/opentibia/yatc?shareId=XXXX-XXXX-XXXX-XXXX).
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ivucica
commented
Feb 6, 2026
|
|
||
| m_screen = NULL; | ||
| m_screen = nullptr; | ||
|
|
Member
Author
There was a problem hiding this comment.
Unnecessary use of C++-style name for the same thing. No need to modify existing code like this.
ivucica
commented
Feb 6, 2026
Member
Author
ivucica
left a comment
ivucica
left a comment
There was a problem hiding this comment.
Trying to give approval
| @@ -121,12 +121,12 @@ bool MiniMapArea::load() | |||
| //Create the sprite | |||
| // FIXME (nfries88): OpenGL does not work well when SDL is being used on the screen. | |||
| // this operation must be changed for GL engine to work. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, incomplete. This was the idea:
Update the codebase to use an abstract RGBA storage class instead of SDL_Surface* for RGBA data storage.
rgba_storage.hto define an abstract classRGBAStoragewith subclassesSDLSurfaceStorageandOpenGLTextureStorage.sprite.handsprite.cppto replaceSDL_Surface*withstd::shared_ptr<RGBAStorage>and update methods accordingly.spritesdl.cppto useRGBAStoragemethods for accessing RGBA data.spritegl.handspritegl.cppto usestd::shared_ptr<RGBAStorage>for RGBA data storage.automap.cppto usestd::shared_ptr<RGBAStorage>for RGBA data storage.engine.cppto usestd::shared_ptr<RGBAStorage>for RGBA data storage.For more details, open the Copilot Workspace session.