OCPBUGS-30045: [4.15] cherry-pick containernetworking/plugins#997 #155

ormergi · 2024-02-28T16:10:37Z

https://issues.redhat.com/browse/CNV-38720, this PR back ports #154

The new `disableContainerInterface` parameter is added to the bridge plugin to enable setting the container interface state down. When the parameter is enabled, the container interface (veth peer that is placed at the container ns) remain down (i.e: disabled). The bridge and host peer interfaces state are not affected by the parameter. Since IPAM logic involve various configurations including waiting for addresses to be realized and setting the interface state UP, the new parameter cannot work with IPAM. In case both IPAM and DisableContainerInterface parameters are set, the bridge plugin will raise an error. Signed-off-by: Or Mergi <[email protected]>

openshift-ci-robot · 2024-02-28T16:11:57Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.16.0" instead
expected Jira Issue OCPBUGS-30045 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-02-28T16:13:08Z

/jira refresh

openshift-ci-robot · 2024-02-28T16:13:12Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected Jira Issue OCPBUGS-30045 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-02-28T16:13:15Z

Hi @ormergi. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ormergi · 2024-02-28T16:14:32Z

/jira refresh

openshift-ci-robot · 2024-02-28T16:14:35Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected Jira Issue OCPBUGS-30045 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-02-28T16:15:08Z

/jira refresh

openshift-ci-robot · 2024-02-28T16:15:12Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected Jira Issue OCPBUGS-30045 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dougbtv · 2024-02-28T19:36:10Z

/approve

dougbtv · 2024-02-28T19:36:13Z

/lgtm

dougbtv · 2024-02-28T19:36:19Z

/label backport-risk-assessed

ormergi · 2024-02-29T10:08:38Z

/jira refresh

openshift-ci-robot · 2024-02-29T10:09:11Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
bug has dependents
dependent bug CNV-28040 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-02-29T10:11:24Z

/jira refresh

openshift-ci-robot · 2024-02-29T10:11:53Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected dependent Jira Issue OCPBUGS-29888 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-02-29T10:11:55Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected dependent Jira Issue OCPBUGS-29888 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-02-29T10:28:05Z

/jira refresh

openshift-ci-robot · 2024-02-29T10:28:59Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected Jira Issue OCPBUGS-30045 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

anuragthehatter · 2024-02-29T15:46:41Z

/label cherry-pick-appoved

openshift-ci · 2024-02-29T15:46:49Z

@anuragthehatter: The label(s) /label cherry-pick-appoved cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

anuragthehatter · 2024-02-29T15:47:13Z

/label cherry-pick-approved

ormergi · 2024-02-29T21:38:34Z

/jira refresh

openshift-ci-robot · 2024-02-29T21:38:38Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected Jira Issue OCPBUGS-30045 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-02-29T21:39:54Z

/jira refresh

openshift-ci-robot · 2024-02-29T21:39:57Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected Jira Issue OCPBUGS-30045 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-02-29T21:42:07Z

/jira refresh

openshift-ci-robot · 2024-02-29T21:42:11Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
bug has dependents
dependent bug CNV-28040 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-02-29T22:11:12Z

/jira refresh

openshift-ci-robot · 2024-02-29T22:11:16Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected dependent Jira Issue OCPBUGS-29888 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-03-04T08:16:18Z

/jira refresh

openshift-ci-robot · 2024-03-04T08:16:22Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is invalid:

expected dependent Jira Issue OCPBUGS-29888 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ormergi · 2024-03-20T10:02:11Z

/jira refresh

openshift-ci-robot · 2024-03-20T10:02:19Z

@ormergi: This pull request references Jira Issue OCPBUGS-30045, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-29888 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-29888 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-03-20T10:05:01Z

@ormergi: Jira Issue OCPBUGS-30045: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30045 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-03-20T10:56:33Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-containernetworking-plugins-container-v4.15.0-202403200621.p0.g401d350.assembly.stream.el8 for distgit ose-containernetworking-plugins.
All builds following this will include this PR.

openshift-merge-robot · 2024-03-21T15:39:59Z

Fix included in accepted release 4.15.0-0.nightly-2024-03-21-020635

ormergi changed the title ~~cherry-pick containernetworking/plugins#997~~ OCPBUGS-30045: cherry-pick containernetworking/plugins#997 Feb 28, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 28, 2024

openshift-ci bot requested review from dcbw and fepan February 28, 2024 16:13

openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2024

ormergi changed the title ~~OCPBUGS-30045: cherry-pick containernetworking/plugins#997~~ OCPBUGS-30045: [4.15] cherry-pick containernetworking/plugins#997 Feb 28, 2024

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 28, 2024

openshift-ci bot assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, weliang1, yingwang-0320 and zhaozhanqi Feb 28, 2024

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 29, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 20, 2024

openshift-merge-bot bot merged commit 401d350 into openshift:release-4.15 Mar 20, 2024

ormergi mentioned this pull request Dec 23, 2024

OCPBUGS-46121: [4.14] cherry-pick containernetworking/plugins#997 #168

Merged

OCPBUGS-30045: [4.15] cherry-pick containernetworking/plugins#997 #155

OCPBUGS-30045: [4.15] cherry-pick containernetworking/plugins#997 #155

Uh oh!

Conversation

ormergi commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 28, 2024

Uh oh!

ormergi commented Feb 28, 2024

Uh oh!

openshift-ci-robot commented Feb 28, 2024

Uh oh!

openshift-ci bot commented Feb 28, 2024

Uh oh!

ormergi commented Feb 28, 2024

Uh oh!

openshift-ci-robot commented Feb 28, 2024

Uh oh!

ormergi commented Feb 28, 2024

Uh oh!

openshift-ci-robot commented Feb 28, 2024

Uh oh!

dougbtv commented Feb 28, 2024

Uh oh!

dougbtv commented Feb 28, 2024

Uh oh!

dougbtv commented Feb 28, 2024

Uh oh!

ormergi commented Feb 29, 2024

Uh oh!

openshift-ci-robot commented Feb 29, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ormergi commented Feb 29, 2024

Uh oh!

openshift-ci-robot commented Feb 29, 2024

Uh oh!

openshift-ci-robot commented Feb 29, 2024

Uh oh!

ormergi commented Feb 29, 2024

Uh oh!

openshift-ci-robot commented Feb 29, 2024

Uh oh!

anuragthehatter commented Feb 29, 2024

Uh oh!

openshift-ci bot commented Feb 29, 2024

Uh oh!

anuragthehatter commented Feb 29, 2024

Uh oh!

ormergi commented Feb 29, 2024

Uh oh!

openshift-ci-robot commented Feb 29, 2024

Uh oh!

ormergi commented Feb 29, 2024

Uh oh!

openshift-ci-robot commented Feb 29, 2024

Uh oh!

ormergi commented Feb 29, 2024

Uh oh!

openshift-ci-robot commented Feb 29, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ormergi commented Feb 29, 2024

Uh oh!

openshift-ci-robot commented Feb 29, 2024

Uh oh!

ormergi commented Mar 4, 2024

Uh oh!

openshift-ci-robot commented Mar 4, 2024

Uh oh!

ormergi commented Mar 20, 2024

Uh oh!

openshift-ci-robot commented Mar 20, 2024

Uh oh!

openshift-ci-robot commented Mar 20, 2024

Uh oh!

openshift-bot commented Mar 20, 2024

Uh oh!

openshift-merge-robot commented Mar 21, 2024

ormergi commented Feb 28, 2024 •

edited

Loading

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 29, 2024 •

edited by openshift-ci bot

Loading