OCPBUGS-29888: cherry-pick containernetworking/plugins#997 #154
Conversation
The new `disableContainerInterface` parameter is added to the bridge plugin to enable setting the container interface state down. When the parameter is enabled, the container interface (veth peer that is placed at the container ns) remain down (i.e: disabled). The bridge and host peer interfaces state are not affected by the parameter. Since IPAM logic involve various configurations including waiting for addresses to be realized and setting the interface state UP, the new parameter cannot work with IPAM. In case both IPAM and DisableContainerInterface parameters are set, the bridge plugin will raise an error. Signed-off-by: Or Mergi <[email protected]>
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @ormergi. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, ormergi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ormergi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ormergi
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@ormergi: This pull request references Jira Issue OCPBUGS-29888, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@ormergi: This pull request references Jira Issue OCPBUGS-29888, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@ormergi: This pull request references Jira Issue OCPBUGS-29888, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@ormergi: This pull request references Jira Issue OCPBUGS-29888, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ormergi: An error was encountered invalid pull identifier: could not parse 154#issuecomment-1960034239 as number for bug OCPBUGS-29888 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
strconv.Atoi: parsing "154#issuecomment-1960034239": invalid syntax
Please contact an administrator to resolve this issue, then request a bug refresh with Jira Issue OCPBUGS-29888 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-containernetworking-plugins-container-v4.16.0-202402231109.p0.ga78d0c2.assembly.stream.el8 for distgit ose-containernetworking-plugins. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-02-26-013420 |
|
Fix included in accepted release 4.15.0-0.nightly-2024-03-21-020635 |
5 participants
Following https://issues.redhat.com/browse/CNV-28040, this PR cherry-picks containernetworking/plugins#997