PluginList: Dont clear every time the tab is opened #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added manual refresh button
codecat
requested changes
Jun 6, 2025
Comment on lines
57
to
62
| void StartRequest() | ||
| { | ||
| Clear(); | ||
| StartRequestForPage(0); | ||
| if (m_pageCount == 0) { | ||
| StartRequestForPage(0); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This conditional logic should probably come from CheckStartRequest, not StartRequest. Additionally, only doing this when the page count is 0 feels wrong - why specifically that?
Comment on lines
+174
to
+178
| if (UI::Button(Icons::Repeat + " Refresh")) { | ||
| Clear(); | ||
| StartRequestForPage(0); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This is not a very good looking button. We should probably make this look a bit more interesting - maybe it could be displayed as a (smaller) button in the top right corner.
|
|
||
| if (m_request !is null && !m_request.Finished() && m_pageCount > 0) { | ||
| UI::PushFont(g_fontBold); | ||
| UI::Text("\\$7f7Loading more items...\\$z"); |
Member
There was a problem hiding this comment.
No need for the \$z here. We may also not want this to be green, but just a gray instead - we can use UI::TextDisabled for. I also don't think this needs to be bold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the Plugin List so that it keeps the list loaded when switching tabs
Closes #38
Added a refresh button to manually refresh the list.