refactor: remove deprecated sidebar toggles#37983
Merged
brian-smith-tcril merged 1 commit intoopenedx:masterfrom Feb 9, 2026
Merged
refactor: remove deprecated sidebar toggles#37983brian-smith-tcril merged 1 commit intoopenedx:masterfrom
brian-smith-tcril merged 1 commit intoopenedx:masterfrom
Conversation
brian-smith-tcril
force-pushed
the
remove-deprd-sidebar-toggles
branch
5 times, most recently
from
3c1249e to
94a3c57
Compare
brian-smith-tcril
added
the
create-sandbox
brian-smith-tcril
force-pushed
the
remove-deprd-sidebar-toggles
branch
from
94a3c57 to
69465d4
Compare
brian-smith-tcril
added
create-sandbox
Contributor
Author
|
I'm not sure what's happening with codecov 
|
brian-smith-tcril
force-pushed
the
remove-deprd-sidebar-toggles
branch
from
69465d4 to
0bb0849
Compare
kdmccormick
approved these changes
Feb 9, 2026
Member
kdmccormick
left a comment
kdmccormick
left a comment
There was a problem hiding this comment.
Thank you! I did not manually test but I did grep for any dangling references and found none.
Could you tidy up the PR description before merging?
| "enable_navigation_sidebar": COURSEWARE_MICROFRONTEND_ENABLE_NAVIGATION_SIDEBAR.is_enabled(course_key), | ||
| "always_open_auxiliary_sidebar": COURSEWARE_MICROFRONTEND_ALWAYS_OPEN_AUXILIARY_SIDEBAR.is_enabled(course_key), | ||
| # Add completion tracking status for the sidebar use while a global place for switches is put in place | ||
| "enable_completion_tracking": ENABLE_COMPLETION_TRACKING_SWITCH.is_enabled() |
Member
There was a problem hiding this comment.
it's pretty silly to have a REST API just for as single switch. even siller that it's parameterized on the course_id while the switch is site-wide. it would make a lot more sense if this were a waffle flag which got fed to the MFE Config API. (no changes needed, not a problem for now--just writing down my thoughts while I'm here.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the sidebar toggles that have been deprecated. See
The learning MFE no longer uses these, and site operators can instead now customize this behavior by utilizing Frontend Plugin Framework slots. See
Testing instructions
I verified the Learning MFE renders properly and does not produce any API errors, both locally and in the PR sandbox.