RHAIENG-948: update subscription value to "true" in build-notebooks-pr-aipcc workflow and when building on push in rhds/notebooks

[jiridanek]

Description

https://issues.redhat.com/browse/RHAIENG-948

How Has This Been Tested?

• https://github.com/jiridanek/notebooks/actions/runs/19299930162

Tried this out first in

• RHAIENG-948: update subscription value to "true" in build-notebooks-p… red-hat-data-services/notebooks#1689

Self checklist (all need to be checked):

• Ensure that you have run make test (gmake on macOS) before asking for review
• Changes to everything except Dockerfile.konflux files should be done in odh/notebooks and automatically synced to rhds/notebooks. For Konflux-specific changes, modify Dockerfile.konflux files directly in rhds/notebooks as these require special attention in the downstream repository and flow to the upcoming RHOAI release.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

Summary by CodeRabbit

• Chores
  • Updated GitHub Actions workflows for notebook builds to refine subscription configuration handling across pull request validation and main branch deployment scenarios, with improved repository-aware logic for optimized build consistency.

[coderabbitai]

Walkthrough

The pull request modifies GitHub Actions workflow configurations to adjust subscription handling logic across build processes. One workflow hardcodes a subscription value to "true", while another implements a conditional fallback that enables subscriptions when building from a specific repository.

Changes

Cohort / File(s)	Summary
Subscription logic adjustments in build workflows .github/workflows/build-notebooks-pr-aipcc.yaml, .github/workflows/build-notebooks-push.yaml	Modified subscription parameter handling: build-notebooks-pr-aipcc.yaml replaces matrix-derived value with constant "true" with explanatory comment; build-notebooks-push.yaml implements fallback logic using OR condition to enable subscriptions for red-hat-data-services/notebooks repository or when matrix.subscription is set.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Both changes follow a consistent pattern of adjusting subscription configuration in related workflows
• Changes are localized to conditional/parameter assignments without complex logic
• Verify that the subscription fallback logic correctly targets the intended repository and doesn't unintentionally affect other build processes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is incomplete with all checklist items unchecked and merge criteria not confirmed, though it includes references to related issue and testing evidence.	Check all items in the self-checklist and merge criteria checkboxes to confirm compliance. Add explicit confirmation that make test was run and testing instructions in the PR body.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main changes: updating subscription values in two workflow files for specific scenarios.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@jiridanek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	2356951	link	true	/test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ide-developer
Once this PR has been reviewed and has the lgtm label, please assign harshad16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment