-
Notifications
You must be signed in to change notification settings - Fork 124
RHAIENG-948: chore(rstudio): add conditional subscription-manager refresh
#2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBoth CPU and CUDA variant Dockerfiles for RHEL9 Python 3.12 add conditional subscription-manager checks during base stage image build. If subscription-manager exists, identity and refresh commands execute; otherwise a fallback message outputs. Package upgrade steps remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jiridanek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ide-developer, ysok The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
follows up on
https://issues.redhat.com/browse/RHAIENG-948
Description
we may have c9s, ubi9, as well as rhel9, either already subscribed or not; every case must be handled
when there is subscription-manager present, we need to then check if we are pre-subscribed or not, and if we are, we refresh the subscription
it is a mistake trying to run subscription-manger on c9s (binary not present) or when we are not pre-subscribed (refresh fails)
this should be the universal pattern applicable in odh-io as well as rhods
How Has This Been Tested?
Tried this out first in
Self checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria:
Summary by CodeRabbit