gnoi/factory_reset: add Decommission RPC #301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add RPC to allow network operator to perform decommission of the device.
Pull Request Test Coverage Report for Build 17272350828Details
💛 - Coveralls |
marcushines
reviewed
Sep 23, 2025
| // To facilitate a response being returned to the caller, the reboot | ||
| // component of this RPC is asynchronous and will run after the RPC | ||
| // has returned a DecommissionResponse. | ||
| rpc Decommission(DecommissionRequest) returns (DecommissionResponse); |
Contributor
There was a problem hiding this comment.
I am not understanding the use case here
does this imply the device will actually no longer try to secure boot as well?
I am not seeing how this significantly different than just the Start with at most a new parameter?
Does this API actually have a different "caller" set which would make it at least a different auth requirement?
Member
There was a problem hiding this comment.
why not augment the Start RPC instead?
LimeHat
reviewed
Sep 23, 2025
| message DecommissionRequest{ | ||
| // Time (in nanoseconds) that the Target should | ||
| // wait before issuing the reboot to complete the decommission. | ||
| // If unset, the Target will assume a default of 15000000000 (15 seconds) |
There was a problem hiding this comment.
How the delay is calculated?
- from the time the target has received a request (which implies that the entire operation takes <=15 seconds by default), or
- from the time the target completed prep. steps and is ready to undergo a reboot?
If it's the former, I'd suggest removing the fixed default value, since the procedure can require more than 15 seconds of execution on the target device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add RPC to allow network operator to
perform decommission of the device.