factory_reset: add mechanism to delete images #294
Closed
+141
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a way to delete images on the system before proceeding with the factory reset.
LimeHat
suggested changes
Aug 21, 2025
| enum DeleteImages { | ||
| // do not delete any images. | ||
| UNSPECIFIED = 0; | ||
| // delete only images which the target deems sensitive |
There was a problem hiding this comment.
any guidance for vendors on this sensitive part? this is very vague.
| // delete only images which the target deems sensitive | ||
| SENSITIVE_IMAGES = 1; | ||
| // delete all images on the target (including sensitive images) | ||
| ALL_IMAGES = 2; |
There was a problem hiding this comment.
does this mean that the node will not be able to boot again without manual intervention?
Contributor
Author
|
superseded by #301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to delete images on the system before proceeding with the factory reset.