refactor: Configure & Fix Detekt Issues for KMP #2765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
As part of the Detekt fixes and refactoring, I made the following improvements: Introduced MifosTextFieldConfig, but since it will be used across multiple modules, it would be better to move it to the model module for better maintainability and reusability. |
niyajali
approved these changes
Feb 9, 2025
niyajali
added
firebase-test-on
niyajali
approved these changes
Feb 10, 2025
Collaborator
|
@HekmatullahAmin can you rebase your PR |
niyajali
added
firebase-test-on
- **Refactored `MifosOutlinedTextField`**: - Introduced `MifosTextFieldConfig` to **reduce parameters** and improve readability. - **Reorganized Composable Functions**: - Fixed **property order** in `@Composable` functions for better clarity. - **Commented out unused properties & methods** to reduce clutter. - **Split large functions into smaller, reusable chunks**. - **Reduced Return Count**: - Ensured functions return at most **two values** to enhance maintainability. - **Updated Detekt Configuration for KMP**: - **Excluded platform-specific files** (`.jvm.kt`, `.desktop.kt`, `.wasmJs.kt`, `.native.kt`, `.js.kt`, `.android.kt`) from `MatchingDeclarationName`.
HekmatullahAmin
force-pushed
the
MM-131
branch
from
ea4fc70 to
bf7d22d
Compare
Member
Author
sure, it is done |
revanthkumarJ
pushed a commit
to revanthkumarJ/mifos-mobile
that referenced
this pull request
Feb 13, 2025
Nagarjuna0033
pushed a commit
to Nagarjuna0033/mifos-mobile
that referenced
this pull request
May 12, 2025
therajanmaurya
pushed a commit
that referenced
this pull request
May 13, 2025
Samriddhi743
pushed a commit
to Samriddhi743/mifos-mobile
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MifosOutlinedTextField:MifosTextFieldConfigto reduce parameters and improve readability.@Composablefunctions for better clarity..jvm.kt,.desktop.kt,.wasmJs.kt,.native.kt,.js.kt,.android.kt) fromMatchingDeclarationName.Fixes - Jira-#131
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.