refactor: Configure & Fix Detekt Issues for KMP (openMF#2765)

Author: HekmatullahAmin

build-logic/convention/src/main/kotlin/org/mifos/mobile/Detekt.kt

@@ -9,6 +9,14 @@ import org.gradle.kotlin.dsl.named
 internal fun Project.configureDetekt(extension: DetektExtension) = extension.apply {
     tasks.named<Detekt>("detekt") {
         jvmTarget = "17"
+        source(files(rootDir))
+        include("**/*.kt")
+        exclude("**/*.kts")
+        exclude("**/resources/**")
+        exclude("**/build/**")
+        exclude("**/generated/**")
+        exclude("**/build-logic/**")
+        exclude("**/spotless/**")
         reports {
             xml.required.set(true)
             html.required.set(true)

cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt

@@ -26,7 +26,7 @@ const val WELCOME_ROUTE = "home_route"
 @Composable
 internal fun FeatureNavHost(
     appState: AppState,
-    onClickLogout: () -> Unit,
+//    onClickLogout: () -> Unit,
     modifier: Modifier = Modifier,
 ) {
     NavHost(
@@ -46,9 +46,11 @@ fun NavGraphBuilder.homeScreen() {
 }
 
 @Composable
-fun WelcomeScreen() {
+fun WelcomeScreen(
+    modifier: Modifier = Modifier,
+) {
     Column(
-        modifier = Modifier.fillMaxSize(),
+        modifier = modifier.fillMaxSize(),
         verticalArrangement = Arrangement.Center,
         horizontalAlignment = Alignment.CenterHorizontally,
     ) {

cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/RootNavGraph.kt

@@ -32,7 +32,6 @@ fun RootNavGraph(
     ) {
         composable(MAIN_GRAPH) {
             App(
-                modifier = modifier,
                 networkMonitor = networkMonitor,
             )
         }

cmp-navigation/src/commonMain/kotlin/cmp/navigation/ui/App.kt

@@ -79,7 +79,7 @@ fun App(
             ) {
                 FeatureNavHost(
                     appState = appState,
-                    onClickLogout = {},
+//                    onClickLogout = {},
                     modifier = Modifier,
                 )
             }

config/detekt/detekt.yml

@@ -450,6 +450,13 @@ naming:
   MatchingDeclarationName:
     active: true
     mustBeFirst: true
+    excludes:
+      - "**/*.jvm.kt"
+      - "**/*.desktop.kt"
+      - "**/*.wasmJs.kt"
+      - "**/*.native.kt"
+      - "**/*.js.kt"
+      - "**/*.android.kt"
   MemberNameEqualsClassName:
     active: true
     ignoreOverridden: true

core/common/src/commonMain/kotlin/org/mifos/mobile/core/common/utils/StringExtensions.kt

@@ -28,6 +28,6 @@ fun maskString(input: String, maskChar: Char = '*'): String {
     }
 }
 
-fun String.capitalizeWords(): String = split(" ").joinToString(" ") { it ->
-    it.replaceFirstChar { if (it.isLowerCase()) it.titlecase() else it.toString() }
+fun String.capitalizeWords(): String = split(" ").joinToString(" ") { string ->
+    string.replaceFirstChar { if (it.isLowerCase()) it.titlecase() else it.toString() }
 }

core/database/src/commonMain/kotlin/org/mifos/mobile/core/database/Room.kt

@@ -58,13 +58,11 @@ expect annotation class Entity(
     val ignoredColumns: Array<String>,
 )
 
-class OnConflictStrategy {
-    companion object {
-        const val NONE = 0
-        const val REPLACE = 1
-        const val ROLLBACK = 2
-        const val ABORT = 3
-        const val FAIL = 4
-        const val IGNORE = 5
-    }
+object OnConflictStrategy {
+    const val NONE = 0
+    const val REPLACE = 1
+    const val ROLLBACK = 2
+    const val ABORT = 3
+    const val FAIL = 4
+    const val IGNORE = 5
 }

core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/UserPreferencesRepositoryImpl.kt

@@ -22,7 +22,7 @@ import org.mifos.mobile.core.datastore.model.UserData
 
 class UserPreferencesRepositoryImpl(
     private val preferenceManager: UserPreferencesDataSource,
-    private val ioDispatcher: CoroutineDispatcher,
+//    private val ioDispatcher: CoroutineDispatcher,
     unconfinedDispatcher: CoroutineDispatcher,
 ) : UserPreferencesRepository {
     private val unconfinedScope = CoroutineScope(unconfinedDispatcher)

core/datastore/src/commonMain/kotlin/org/mifos/mobile/core/datastore/di/PreferenceModule.kt

@@ -29,7 +29,7 @@ val PreferencesModule = module {
     single<UserPreferencesRepository> {
         UserPreferencesRepositoryImpl(
             preferenceManager = get(),
-            ioDispatcher = get(named(MifosDispatchers.IO.name)),
+//            ioDispatcher = get(named(MifosDispatchers.IO.name)),
             unconfinedDispatcher = get(named(MifosDispatchers.Unconfined.name)),
         )
     }

core/designsystem/src/commonMain/kotlin/org/mifos/mobile/core/designsystem/component/MifosLoadingDialog.kt

@@ -35,6 +35,7 @@ import org.mifos.mobile.core.designsystem.theme.MifosMobileTheme
 @Composable
 fun MifosLoadingDialog(
     visibilityState: LoadingDialogState,
+    modifier: Modifier = Modifier,
 ) {
     when (visibilityState) {
         is LoadingDialogState.Hidden -> Unit
@@ -51,7 +52,7 @@ fun MifosLoadingDialog(
                     colors = CardDefaults.cardColors(
                         containerColor = MaterialTheme.colorScheme.surfaceContainerHigh,
                     ),
-                    modifier = Modifier
+                    modifier = modifier
                         .semantics {
                             testTag = "AlertPopup"
                         }