Skip to content

Add noEvent for dT in ExteriorConvection component #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelgerjansen merged 7 commits into from
Sep 24, 2025
Merged

Add noEvent for dT in ExteriorConvection component #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
96cabd4
Add noEvent for dT in ExteriorConvection
jelgerjansen Sep 19, 2025
8980a22
Remove obsolete annotation
jelgerjansen Sep 19, 2025
ef4f85c
Update reference results BeamRadiationOnFloor
jelgerjansen Sep 19, 2025
aef2cda
Update reference results InternalGainExample
jelgerjansen Sep 19, 2025
02f4335
Update reference results IDEAS.Buildings.Validation.Tests
jelgerjansen Sep 19, 2025
296d335
Update reference results IDEAS.Templates
jelgerjansen Sep 22, 2025
44760e4
Update reference results IDEAS.Examples
jelgerjansen Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions IDEAS/Buildings/Components/BaseClasses/ConvectiveHeatTransfer/ExteriorConvection.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,18 @@ protected

Real C "TARP coeff";
Modelica.Units.SI.TemperatureDifference dT
"Surface temperature minus outdoor air temperature" annotation ();
"Surface temperature minus outdoor air temperature";
equation

// Assign empirical coefficient according to flow regime.
if isCeiling then
if dT > 0 then
if noEvent(dT > 0) then
C = C_horz_buoyant;
else
C = C_horz_stable;
end if;
elseif isFloor then
if dT < 0 then
if noEvent(dT < 0) then
C = C_horz_buoyant;
else
C = C_horz_stable;
Expand Down Expand Up @@ -136,6 +136,11 @@ than 1 are discouraged as there appears to be little physical basis for this fac
</html>", revisions="<html>
<ul>
<li>
September 19, 2025, by Jelger Jansen:<br/>
Include <code>noEvent</code> to avoid state events when sign of <code>dT</code> changes.
This is for <a href=\"https://github.com/open-ideas/IDEAS/issues/1464\">#1464</a>.
</li>
<li>
August 9, 2022, by Filip Jorissen:<br/>
Updated documentation and revised interface for issue
<a href=\"https://github.com/open-ideas/IDEAS/issues/1270\">#1270</a>.
Expand Down
10 changes: 5 additions & 5 deletions ...rces/ReferenceResults/Dymola/IDEAS_Buildings_Components_Examples_BeamRadiationOnFloor.txt
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions IDEAS/Resources/ReferenceResults/Dymola/IDEAS_Buildings_Examples_InternalGainExample.txt
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions IDEAS/Resources/ReferenceResults/Dymola/IDEAS_Buildings_Validation_Tests_Case630.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
last-generated=2024-10-29
last-generated=2025-09-19
statistics-initialization=
{
"linear": "2, 2",
Expand All @@ -13,7 +13,7 @@ statistics-simulation=
"numerical Jacobians": "0"
}
time=[0e+00, 1e+06]
Case630.building.heatPortCon[1].T=[2.931499938964844e+02, 2.931309509277344e+02, 2.931288350423177e+02, 2.931325988769531e+02, 2.931441243489583e+02, 2.931486918131511e+02, 2.938932495117188e+02, 2.931354166666667e+02, 2.931301676432292e+02, 2.931238708496094e+02, 2.931187438964844e+02, 2.931152648925781e+02, 2.931144714355469e+02, 2.931144307454427e+02, 2.931124046673867e+02, 2.931083984375e+02, 2.931070658365886e+02, 2.931056925455729e+02, 2.931058349609375e+02, 2.931055399576823e+02, 2.931039632161458e+02, 2.931065673828125e+02, 2.931166585286458e+02, 2.931205749511719e+02, 2.931064453125e+02, 2.931039021809896e+02, 2.931026814778646e+02, 2.9310009765625e+02, 2.930998026529948e+02, 2.931093139648438e+02, 2.931247253417969e+02, 2.931273905436198e+02, 2.931217651367188e+02, 2.931074829101562e+02, 2.931053873697917e+02, 2.931061706542969e+02, 2.931175231933594e+02, 2.931150614420573e+02, 2.931401062011719e+02, 2.931450805664062e+02, 2.932798461914062e+02, 2.931368509928386e+02, 2.931280212402344e+02, 2.931254781087239e+02, 2.931244405110677e+02, 2.931261901855469e+02, 2.9312646484375e+02, 2.931494242350261e+02, 2.942323913574219e+02, 2.965029195149739e+02, 2.931384989420573e+02, 2.931321105957031e+02, 2.931317545572917e+02, 2.931274617513021e+02, 2.931257934570312e+02, 2.931395365397136e+02, 2.931492004394531e+02, 2.931507263183594e+02, 2.931468607584636e+02, 2.931309204101562e+02, 2.931254272460938e+02, 2.931237284342448e+02, 2.931239318847656e+02, 2.931245422363281e+02, 2.931440633138021e+02, 2.931471354166667e+02, 2.94182861328125e+02, 2.931394246419271e+02, 2.931287231445312e+02, 2.93123779296875e+02, 2.9312255859375e+02, 2.931229960123698e+02, 2.931286010742188e+02, 2.931487426757812e+02, 2.941766153971354e+02, 2.9624169921875e+02, 2.931376851399739e+02, 2.931301472981771e+02, 2.931292114257812e+02, 2.931323343912761e+02, 2.931304524739583e+02, 2.931454772949219e+02, 2.942948099772136e+02, 2.966237182617188e+02, 2.960303955078125e+02, 2.931367492675781e+02, 2.931297912597656e+02, 2.9312841796875e+02, 2.931291809082031e+02, 2.931314086914062e+02, 2.931377258300781e+02, 2.931497192382812e+02, 2.968381754557292e+02, 2.931476440429688e+02, 2.931339314778646e+02, 2.931288553873698e+02, 2.931280517578125e+02, 2.931272277832031e+02, 2.931356811523438e+02, 2.939009094238281e+02, 2.955212097167969e+02]
Case630.building.heatPortRad[1].T=[2.931499938964844e+02, 2.896278381347656e+02, 2.890952453613281e+02, 2.896361083984375e+02, 2.919384969075521e+02, 2.932241414388021e+02, 2.943800964355469e+02, 2.904670206705729e+02, 2.893666178385417e+02, 2.88489990234375e+02, 2.877382405598958e+02, 2.872527465820312e+02, 2.871290588378906e+02, 2.872000630696614e+02, 2.869130439777716e+02, 2.863791809082031e+02, 2.861528625488281e+02, 2.859787292480469e+02, 2.859634094238281e+02, 2.859583333333333e+02, 2.857532958984375e+02, 2.862223510742188e+02, 2.877997538248698e+02, 2.890125122070312e+02, 2.863663635253906e+02, 2.857787475585938e+02, 2.856292724609375e+02, 2.85264892578125e+02, 2.852142028808594e+02, 2.86829833984375e+02, 2.892768249511719e+02, 2.896156005859375e+02, 2.891186828613281e+02, 2.864378051757812e+02, 2.859502868652344e+02, 2.859752909342448e+02, 2.869738464355469e+02, 2.871361592610677e+02, 2.916726888020833e+02, 2.92375732421875e+02, 2.941172790527344e+02, 2.911035664876302e+02, 2.891726379394531e+02, 2.886021321614583e+02, 2.8840283203125e+02, 2.886948547363281e+02, 2.888326314290364e+02, 2.936123962402344e+02, 2.948271484375e+02, 2.971378987630208e+02, 2.913142496744792e+02, 2.8975244140625e+02, 2.894592793782552e+02, 2.889006652832031e+02, 2.886131591796875e+02, 2.915542805989583e+02, 2.937874755859375e+02, 2.938449401855469e+02, 2.931435648600261e+02, 2.897297770182292e+02, 2.886707458496094e+02, 2.883320617675781e+02, 2.882996622721354e+02, 2.884192199707031e+02, 2.926752115885417e+02, 2.932599690755208e+02, 2.950131530761719e+02, 2.914986673990886e+02, 2.893042805989583e+02, 2.884158020019531e+02, 2.881564432779948e+02, 2.881760864257812e+02, 2.892823181152344e+02, 2.935647379557292e+02, 2.947868041992188e+02, 2.969349975585938e+02, 2.911008707682292e+02, 2.89438720703125e+02, 2.890645141601562e+02, 2.894660135904948e+02, 2.893011271158854e+02, 2.926443786621094e+02, 2.947856343587239e+02, 2.972091674804688e+02, 2.965601501464844e+02, 2.90866943359375e+02, 2.893554890950521e+02, 2.890041198730469e+02, 2.890182698567708e+02, 2.893779296875e+02, 2.904569091796875e+02, 2.930087280273438e+02, 2.974352823893229e+02, 2.933134460449219e+02, 2.901815490722656e+02, 2.891410115559896e+02, 2.88951416015625e+02, 2.887928365071614e+02, 2.906293741861979e+02, 2.946903991699219e+02, 2.962178955078125e+02]
Case630.PHea=[0e+00, -1.504354573567708e+03, -1.67097314453125e+03, -1.373035766601562e+03, -4.638809000651042e+02, -1.032379659016927e+02, 0e+00, -1.151225056966146e+03, -1.566539306640625e+03, -2.06329150390625e+03, -2.4674228515625e+03, -2.742190104166667e+03, -2.8054130859375e+03, -2.80862060546875e+03, -2.968610932209343e+03, -3.284783447265625e+03, -3.38976171875e+03, -3.498792073567708e+03, -3.48790185546875e+03, -3.510752522786458e+03, -3.634263346354167e+03, -3.4281220703125e+03, -2.633217122395833e+03, -2.323380940755208e+03, -3.43983056640625e+03, -3.64010693359375e+03, -3.735265543619792e+03, -3.94080224609375e+03, -3.962614908854167e+03, -3.213095133463542e+03, -1.995910522460938e+03, -1.785034912109375e+03, -2.229136962890625e+03, -3.35812060546875e+03, -3.522086181640625e+03, -3.460434895833333e+03, -2.5640224609375e+03, -2.75896826171875e+03, -7.805496012369791e+02, -3.874026794433594e+02, 0e+00, -1.038094848632812e+03, -1.734217163085938e+03, -1.935595906575521e+03, -2.018167643229167e+03, -1.88053466796875e+03, -1.858832845052083e+03, -4.652251434326172e+01, 0e+00, 0e+00, -9.080921223958334e+02, -1.412333251953125e+03, -1.440365193684896e+03, -1.779532918294271e+03, -1.91121826171875e+03, -8.264994913736979e+02, -6.241550445556641e+01, 0e+00, -2.485964202880859e+02, -1.506045084635417e+03, -1.941220947265625e+03, -2.073736979166667e+03, -2.057912760416667e+03, -2.010919311523438e+03, -4.694900817871094e+02, -2.259062906901042e+02, 0e+00, -8.342987060546875e+02, -1.68027587890625e+03, -2.06979833984375e+03, -2.165962646484375e+03, -2.1312890625e+03, -1.690470947265625e+03, -9.868841807047527e+01, 0e+00, 0e+00, -9.733764241536459e+02, -1.567441650390625e+03, -1.640229370117188e+03, -1.394493245442708e+03, -1.543535847981771e+03, -3.563969421386719e+02, 0e+00, 0e+00, 0e+00, -1.04683046468099e+03, -1.596425821940104e+03, -1.703617309570312e+03, -1.644359090169271e+03, -1.466763671875e+03, -9.681203002929688e+02, -2.135997676849365e+01, 0e+00, -1.852866668701172e+02, -1.269016927083333e+03, -1.669730143229167e+03, -1.73306396484375e+03, -1.799034016927083e+03, -1.129646565755208e+03, 0e+00, 0e+00]
Case630.building.heatPortCon[1].T=[2.931499938964844e+02, 2.931309509277344e+02, 2.931288350423177e+02, 2.931325988769531e+02, 2.931441243489583e+02, 2.931486918131511e+02, 2.938933715820312e+02, 2.931354166666667e+02, 2.931301676432292e+02, 2.931238708496094e+02, 2.931187438964844e+02, 2.931152648925781e+02, 2.931144714355469e+02, 2.931144307454427e+02, 2.931123962402344e+02, 2.931083984375e+02, 2.931070658365886e+02, 2.931056925455729e+02, 2.931058349609375e+02, 2.931055399576823e+02, 2.931039632161458e+02, 2.931065673828125e+02, 2.931166585286458e+02, 2.931205749511719e+02, 2.931064453125e+02, 2.931039021809896e+02, 2.931026814778646e+02, 2.9310009765625e+02, 2.930998026529948e+02, 2.931093139648438e+02, 2.931247253417969e+02, 2.931273905436198e+02, 2.931217651367188e+02, 2.931074829101562e+02, 2.931053873697917e+02, 2.931061706542969e+02, 2.931175231933594e+02, 2.931150716145833e+02, 2.931401062011719e+02, 2.931450805664062e+02, 2.9327978515625e+02, 2.931368509928386e+02, 2.931280212402344e+02, 2.931254781087239e+02, 2.931244405110677e+02, 2.931261901855469e+02, 2.9312646484375e+02, 2.931494242350261e+02, 2.94232421875e+02, 2.965031026204427e+02, 2.931384989420573e+02, 2.931321105957031e+02, 2.931317545572917e+02, 2.931274617513021e+02, 2.931257934570312e+02, 2.931395365397136e+02, 2.931492004394531e+02, 2.931507263183594e+02, 2.931468607584636e+02, 2.931309204101562e+02, 2.931254272460938e+02, 2.931237284342448e+02, 2.931239318847656e+02, 2.931245422363281e+02, 2.931440633138021e+02, 2.931471354166667e+02, 2.94182861328125e+02, 2.931394246419271e+02, 2.931287231445312e+02, 2.93123779296875e+02, 2.9312255859375e+02, 2.931229960123698e+02, 2.931286010742188e+02, 2.931487426757812e+02, 2.941765848795573e+02, 2.962418518066406e+02, 2.931376851399739e+02, 2.931301472981771e+02, 2.931292114257812e+02, 2.931323343912761e+02, 2.931304524739583e+02, 2.931454772949219e+02, 2.942946573893229e+02, 2.966236267089844e+02, 2.960303955078125e+02, 2.931367492675781e+02, 2.931297912597656e+02, 2.9312841796875e+02, 2.931291809082031e+02, 2.931314086914062e+02, 2.931377258300781e+02, 2.931497192382812e+02, 2.968381449381511e+02, 2.931476440429688e+02, 2.931339314778646e+02, 2.931288553873698e+02, 2.931280517578125e+02, 2.931272277832031e+02, 2.931356811523438e+02, 2.939010009765625e+02, 2.955211791992188e+02]
Case630.building.heatPortRad[1].T=[2.931499938964844e+02, 2.896278381347656e+02, 2.8909521484375e+02, 2.896361083984375e+02, 2.919385477701823e+02, 2.93224365234375e+02, 2.943802185058594e+02, 2.904670511881511e+02, 2.893666178385417e+02, 2.88489990234375e+02, 2.877382405598958e+02, 2.872527262369792e+02, 2.871290588378906e+02, 2.872000834147136e+02, 2.869130249023438e+02, 2.863791809082031e+02, 2.861528422037761e+02, 2.859786682128906e+02, 2.859634094238281e+02, 2.859583333333333e+02, 2.857532958984375e+02, 2.862223510742188e+02, 2.877997538248698e+02, 2.890125427246094e+02, 2.863663635253906e+02, 2.857787475585938e+02, 2.856292724609375e+02, 2.852648620605469e+02, 2.852142028808594e+02, 2.868297424316406e+02, 2.892768249511719e+02, 2.896156921386719e+02, 2.891186625162761e+02, 2.864377136230469e+02, 2.859502868652344e+02, 2.859752705891927e+02, 2.869738464355469e+02, 2.871361897786458e+02, 2.916727193196614e+02, 2.923757019042969e+02, 2.941171875e+02, 2.911036275227864e+02, 2.89172607421875e+02, 2.886021321614583e+02, 2.8840283203125e+02, 2.886949157714844e+02, 2.888326416015625e+02, 2.936124369303386e+02, 2.948272094726562e+02, 2.971380920410156e+02, 2.913143107096354e+02, 2.8975244140625e+02, 2.894593098958333e+02, 2.889006652832031e+02, 2.886131591796875e+02, 2.915542500813802e+02, 2.937874450683594e+02, 2.938449401855469e+02, 2.931435953776042e+02, 2.897297770182292e+02, 2.886707763671875e+02, 2.883320109049479e+02, 2.882996622721354e+02, 2.884192199707031e+02, 2.926751607259114e+02, 2.932599182128906e+02, 2.950131530761719e+02, 2.914987589518229e+02, 2.893043111165364e+02, 2.88415771484375e+02, 2.881564432779948e+02, 2.881760864257812e+02, 2.892822570800781e+02, 2.935647481282552e+02, 2.947867635091146e+02, 2.969351501464844e+02, 2.911009012858073e+02, 2.89438720703125e+02, 2.890645141601562e+02, 2.894659932454427e+02, 2.893010965983073e+02, 2.926444396972656e+02, 2.947854817708333e+02, 2.972090657552083e+02, 2.965601806640625e+02, 2.90866943359375e+02, 2.893554890950521e+02, 2.890040893554688e+02, 2.890182393391927e+02, 2.893778991699219e+02, 2.904569091796875e+02, 2.930087687174479e+02, 2.974352518717448e+02, 2.933133544921875e+02, 2.901815490722656e+02, 2.891410115559896e+02, 2.88951416015625e+02, 2.887928365071614e+02, 2.906294555664062e+02, 2.946904907226562e+02, 2.962178039550781e+02]
Case630.PHea=[0e+00, -1.504354085286458e+03, -1.670975138346354e+03, -1.373031494140625e+03, -4.640084737141927e+02, -1.03174690246582e+02, 0e+00, -1.151216105143229e+03, -1.566539306640625e+03, -2.06329248046875e+03, -2.467420328776042e+03, -2.742178873697917e+03, -2.80541064453125e+03, -2.808615234375e+03, -2.968620524088542e+03, -3.284787841796875e+03, -3.389764567057292e+03, -3.498820393880208e+03, -3.4879609375e+03, -3.510759114583333e+03, -3.634269775390625e+03, -3.428257080078125e+03, -2.633212320963542e+03, -2.323376871744792e+03, -3.43982666015625e+03, -3.640108072916667e+03, -3.735276774088542e+03, -3.94080615234375e+03, -3.962615071614583e+03, -3.213131754557292e+03, -1.995905639648438e+03, -1.785007731119792e+03, -2.229146565755208e+03, -3.358155029296875e+03, -3.522077718098958e+03, -3.46043896484375e+03, -2.564028076171875e+03, -2.758945068359375e+03, -7.805406494140625e+02, -3.874075927734375e+02, 0e+00, -1.038070068359375e+03, -1.734232177734375e+03, -1.935595377604167e+03, -2.018180013020833e+03, -1.880557373046875e+03, -1.858824584960938e+03, -4.650488090515137e+01, 0e+00, 0e+00, -9.080747477213541e+02, -1.412330200195312e+03, -1.440360432942708e+03, -1.779533162434896e+03, -1.911215576171875e+03, -8.265067342122396e+02, -6.242446136474609e+01, 0e+00, -2.485242563883463e+02, -1.506046346028646e+03, -1.941213745117188e+03, -2.073755126953125e+03, -2.057914632161458e+03, -2.010914184570312e+03, -4.693937683105469e+02, -2.259190673828125e+02, 0e+00, -8.341653035481771e+02, -1.680270100911458e+03, -2.0698056640625e+03, -2.165939615885417e+03, -2.131289957682292e+03, -1.690498168945312e+03, -9.868200429280598e+01, 0e+00, 0e+00, -9.733680826822916e+02, -1.567442464192708e+03, -1.6402294921875e+03, -1.394499633789062e+03, -1.543549560546875e+03, -3.563842468261719e+02, 0e+00, 0e+00, 0e+00, -1.046829528808594e+03, -1.596422973632812e+03, -1.703629516601562e+03, -1.64437060546875e+03, -1.466770548502604e+03, -9.68125244140625e+02, -2.161581516265869e+01, 0e+00, -1.853095397949219e+02, -1.269022379557292e+03, -1.669726196289062e+03, -1.733062866210938e+03, -1.799033935546875e+03, -1.129625630696615e+03, 0e+00, 0e+00]
Case630.PCoo=[0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00, 0e+00]
Loading