Add noEvent for dT in ExteriorConvection component #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kldjonge, there are some minor changes, but these are very small in both absolute and relative value (see below): Furthermore, there is a significant decrease in state events (which was expected). See below for an example of one of the models. Therefore, I think this PR can be merged. |
Contributor
|
@jelgerjansen, thanks for implementing this! |
annadellisola
approved these changes
Sep 23, 2025
Contributor
annadellisola
left a comment
annadellisola
left a comment
There was a problem hiding this comment.
Thank you @jelgerjansen for addressing the issue. It seems correct and reasonable to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #1464.