ppx: Remove sensitivity to paths passed on the command line #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliom_ppx_client and eliom_ppx_server could be passed different paths to the same files, as Dune execute commands from different current directories. However, this might create collisions if two file have the same name.
|
This does fix the problem that I described in #803. A reproduction is found by running |
|
@vouillon are you happy with this? |
vouillon
approved these changes
Apr 22, 2025
vouillon
added a commit
that referenced
this pull request
Apr 22, 2025
Since we only keep the first 36 bits of the string, we get collisions pretty easily if we use the filename directly.
vouillon
added a commit
that referenced
this pull request
Apr 22, 2025
Since we only keep the first 36 bits of the string, we get collisions pretty easily if we use the filename directly.
vouillon
added a commit
that referenced
this pull request
Apr 23, 2025
Fix #810: keep hashing the filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eliom_ppx_client and eliom_ppx_server could be passed different paths to the same files, as Dune execute commands from different current directories.
However, this might create collisions if two file have the same name.
This was suggested by @vouillon in #803