Fix #810: keep hashing the filename #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we only keep the first 36 bits of the string, we get collisions pretty easily if we use the filename directly.
vouillon
commented
Apr 22, 2025
| @@ -283,7 +283,7 @@ module Cmo = struct | |||
| ; ev_kind = Event_after ty | |||
| ; _ } -> | |||
| if pos_cnum' = pos_cnum + 1 | |||
| then Hashtbl.add events (Filename.basename pos_fname, pos_cnum) ty | |||
There was a problem hiding this comment.
This is only used internally, so we can keep the full path here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we only keep the first 36 bits of the string, we get collisions pretty easily if we use the filename directly.