Skip to content

refactor(datagen): thread an injected logger, drop global-logger use (PIPE-1067) - #277

Open
Dylan-M wants to merge 2 commits into
dylanmyers/pipe-1003-datagen-panic-to-errorfrom
dylanmyers/pipe-1067-eliminate-global-logger
Open

refactor(datagen): thread an injected logger, drop global-logger use (PIPE-1067)#277
Dylan-M wants to merge 2 commits into
dylanmyers/pipe-1003-datagen-panic-to-errorfrom
dylanmyers/pipe-1067-eliminate-global-logger

Conversation

@Dylan-M

@Dylan-M Dylan-M commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Stacked on #276

Proposed Change

Removes global-logger (zap.L() / zap.S()) use so an embedding host has full
control over blitz's log stream.

  • Threads an injected *zap.Logger through datagen's application generation,
    replacing the zap.L().Warn leak. A nil logger disables logging rather than
    falling back to the global.
  • Adds a CI guard (scripts/check-no-global-logger.sh, wired into the Makefile and
    CI) that fails if zap.L() / zap.S() reappears outside bootstrap.

Validation: run the guard script against a tree with a deliberately-added zap.L()
call and confirm it fails. Tests thread the injected logger through and confirm
behavior with a nil logger.

Checklist
  • Changes are tested
  • CI has passed

Dylan-M added 2 commits August 4, 2026 17:30
…lobal-logger call (PIPE-1067)

Assisted-by: Claude Opus 4.8
…uction (PIPE-1067)

Assisted-by: Claude Opus 4.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant