fix(datagen): return errors instead of panicking on developer-error input (PIPE-1003) - #276
Open
Dylan-M wants to merge 2 commits into
Conversation
…er errors (PIPE-1003) Assisted-by: Claude Opus 4.8
…tParseCIDRs for constants (PIPE-1003) Assisted-by: Claude Opus 4.8
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stacked on #275
Proposed Change
Converts datagen's panic-on-developer-error paths to error returns. Blitz is
embeddable, so a panic on recoverable input takes down the host process; these
paths now return an error the host can handle.
GenerateSystemIdentity,GenerateEnvironment, and the group and username pathsreturn an error on nil pointers and invalid input rather than panicking.
parseCIDRsprimitive; the panickingmustParseCIDRsform stays only for parsing compile-time constants.
tests now assert error returns.
Validation: the change has no user-facing surface, so it's exercised through unit
tests. Each converted path returns an error (nil domain, invalid CIDR) rather than
panicking, and the happy paths stay clean.
Checklist