Skip to content

Provide API to work with session key binary #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Provide API to work with session key binary #704

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17c8f30
session: Fix `Object.SetAuthKey` test
cthulhu-rider Apr 3, 2025
798fc8f
pool/test: Drop redundant assert
cthulhu-rider Apr 3, 2025
e0c7bdb
session: Provide API to work with session key binary
cthulhu-rider Apr 3, 2025
5d0ff1b
pool: Avoid public key encode-decode round
cthulhu-rider Apr 3, 2025
764938f
client/test: Avoid public key encode-decode round in example
cthulhu-rider Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions pool/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
"github.com/google/uuid"
"github.com/nspcc-dev/neofs-sdk-go/client"
cid "github.com/nspcc-dev/neofs-sdk-go/container/id"
neofsecdsa "github.com/nspcc-dev/neofs-sdk-go/crypto/ecdsa"
"github.com/nspcc-dev/neofs-sdk-go/session"
"github.com/nspcc-dev/neofs-sdk-go/user"
)
Expand Down Expand Up @@ -49,13 +48,8 @@ func initSession(ctx context.Context, c *sdkClientWrapper, dur uint64, signer us
return dst, fmt.Errorf("invalid session token ID: %w", err)
}

var key neofsecdsa.PublicKey
if err = key.Decode(res.PublicKey()); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this suggests another inconsistency (SDK-level), sometimes keys are proper keys and sometimes they are bytes. Depends on type.

return dst, fmt.Errorf("invalid public session key: %w", err)
}

dst.SetID(id)
dst.SetAuthKey(&key)
dst.SetAuthKeyBytes(res.PublicKey())
dst.SetExp(exp)

c.nodeSession.SetNodeSession(&dst, signer.Public())
Expand Down