Provide API to work with session key binary #704
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Container.SetAuthKey` was tested by mistake. Signed-off-by: Leonard Lyubich <[email protected]>
Zero (undefined overall) session token is returned from the cache on miss, so it makes no sense to access its fields. Signed-off-by: Leonard Lyubich <[email protected]>
For the sake of transparency and flexibility: struct field is of []byte type. Also, field can be extended within nspcc-dev/neofs-api#305. New methods will allow to adapt variadic format in the app without lib changes. Signed-off-by: Leonard Lyubich <[email protected]>
API added in e0c7bdb allows it. Signed-off-by: Leonard Lyubich <[email protected]>
API added in e0c7bdb allows it. Signed-off-by: Leonard Lyubich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 55.22% 55.25% +0.03%
==========================================
Files 166 166
Lines 22803 22803
==========================================
+ Hits 12593 12600 +7
+ Misses 9937 9931 -6
+ Partials 273 272 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
roman-khimov
reviewed
Apr 3, 2025
|
|
||
| // SetAuthKeyBytes sets binary-encoded public key corresponding to the private key | ||
| // bound to the session. | ||
| func (x *commonData) SetAuthKeyBytes(b []byte) { |
There was a problem hiding this comment.
This makes the API ambiguous to me. If you want raw bytes --- proto/session is here for you.
| } | ||
|
|
||
| var key neofsecdsa.PublicKey | ||
| if err = key.Decode(res.PublicKey()); err != nil { |
There was a problem hiding this comment.
Actually this suggests another inconsistency (SDK-level), sometimes keys are proper keys and sometimes they are bytes. Depends on type.
|
according to nspcc-dev/neofs-api#305 (comment), this is not needed for now, meaning redundant. So i'll leave this PR as a reminder. If we'll need to support smth other than keys, changes may become relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not critical extension for now (nspcc-dev/neofs-api#305 (comment)), but useful in general