Skip to content

build: fix node_use_sqlite for GN builds #59017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

build: fix node_use_sqlite for GN builds #59017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions node.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ declare_args() {
# The variable is called "openssl" for parity with node's GYP build.
node_use_openssl = true

# Build node with SQLite support.
node_use_sqlite = true

# Use the specified path to system CA (PEM format) in addition to
# the BoringSSL supplied CA store or compiled-in Mozilla CA copy.
node_openssl_system_ca_path = ""
Expand Down
10 changes: 9 additions & 1 deletion unofficial.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ template("node_gn_build") {
} else {
defines += [ "HAVE_OPENSSL=0" ]
}
if (node_use_sqlite) {
defines += [ "HAVE_SQLITE=1" ]
} else {
defines += [ "HAVE_SQLITE=0" ]
}
if (node_use_amaro) {
defines += [ "HAVE_AMARO=1" ]
} else {
Expand Down Expand Up @@ -159,7 +164,6 @@ template("node_gn_build") {
"deps/nghttp2",
"deps/ngtcp2",
"deps/postject",
"deps/sqlite",
"deps/uvwasi",
"deps/zstd",
"//third_party/zlib",
Expand Down Expand Up @@ -193,6 +197,10 @@ template("node_gn_build") {
public_deps += [ "$node_openssl_path" ]
sources += gypi_values.node_crypto_sources
}
if (node_use_sqlite) {
deps += [ "deps/sqlite" ]
sources += gypi_values.node_sqlite_sources
}
if (node_enable_inspector) {
deps += [
"$node_inspector_protocol_path:crdtp",
Expand Down
Loading