Skip to content

build: fix node_use_sqlite for GN builds #59017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: fix node_use_sqlite for GN builds #59017

wants to merge 1 commit into from
+12 −1

Conversation

codebytere
Copy link
Member

Refs #58122

Fixes a issue where Sqlite didn't work in GN builds by default after the above PR as the defines weren't correctly set.

@codebytere codebytere requested review from zcbenz and mhdawson July 10, 2025 08:12
@codebytere codebytere mentioned this pull request Jul 10, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@himself65 himself65 himself65 approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@mhdawson mhdawson Awaiting requested review from mhdawson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codebytere @lpinca @targos @himself65