Skip to content

fix(shell): allow attached placement for panels with fill sizing #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Louis047 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(shell): allow attached placement for panels with fill sizing #4017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/shell/panel/panel_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,12 +635,8 @@ void PanelManager::openPanel(const std::string& panelId, PanelOpenRequest reques
};

PanelPlacement activePlacement = m_activePanel->panelPlacement();
const bool fillWidth = m_activePanel->fillsWidth();
const bool fillHeight = m_activePanel->fillsHeight();
if ((fillWidth || fillHeight) && activePlacement != PanelPlacement::Floating) {
kLog.warn("panel manager: \"{}\" uses fill sizing, which requires floating placement — opening floating", panelId);
activePlacement = PanelPlacement::Floating;
}
const bool fillWidth = m_activePanel->fillsWidth() && activePlacement == PanelPlacement::Floating;
const bool fillHeight = m_activePanel->fillsHeight() && activePlacement == PanelPlacement::Floating;
m_panelFillWidth = fillWidth;
m_panelFillHeight = fillHeight;
const bool pluginPanel = m_activePanelId.contains(':');
Expand Down