fix(shell): allow attached placement for panels with fill sizing - #4017
Open
Louis047 wants to merge 1 commit into
Open
fix(shell): allow attached placement for panels with fill sizing#4017Louis047 wants to merge 1 commit into
Louis047 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scopes
fillWidthandfillHeightsurface constraints toFloatingplacement mode and removes the forced fallback to floating inPanelManager::openPanel.Motivation
For plugins using fill sizing such as the
Notesplugin (height = "fill"), setting the panel placement to "Attached" in settings had no effect becausePanelManager::openPanelforcedactivePlacement = PanelPlacement::Floating. Scoping fill sizing to floating mode allows the Notes panel (and any other fill-sized panel) to attach cleanly to the bar when configured as attached, while preserving full-height sidebar behavior when configured as floating.Type of Change
Testing
just build- compiled successfullyjust test- all 89 test suites passedpython3 tools/i18n-check.py- verified 892 translation keysjust lint- 563 files checked with 0 warnings / errorsManual Coverage
Screenshots / Videos
Before:
2026-08-19-21-43-24.mp4
After:
2026-08-19-21-45-23.mp4
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed.Additional Notes
I haven't faced any edge cases with this as I tested other panels in floating mode and they respect their panel sizes correctly without any conflicts