-
-
Notifications
You must be signed in to change notification settings - Fork 2k
refactor(router-store): migrate unit tests to Vitest #5035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(router-store): migrate unit tests to Vitest #5035
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
✅ Deploy Preview for ngrx-site-v19 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Failed test due to snapshot https://github.com/ngrx/platform/actions/runs/19837913910/job/56839569056?pr=5035#step:8:986
Will attempt to fix 🙏🏻 |
Snapshot fixed but build somehow failed. Build failed also on the first run. will look at it. |
This is weird. Build works locally but when run on GH actions, it complains it is missing
The error is not only exclusive to me and it happens also in the PR #5030 (https://github.com/ngrx/platform/actions/runs/19838297217/job/56840791232?pr=5030#step:8:183) |
|
Hey @exequiel09 yeah, I just noticed in my PR and saw your comment, not sure why the error, that command nx run entity:build runs fine locally |
Hey @gabrielguerrero It might be an issue in the pipeline. I guess we'll have to wait for someone in the NgRx team to look at it and provide feedback. |
a9d05b5 to
32e7d13
Compare
Yeah we might need to wait, I think for some reason it doesnt install the store dependency, is a peerDependency so by default is not install but I imagine this must have work some other way before, maybe somethings change in the pipeline that broke it |
270b81e to
c8dd89a
Compare
|
The issue in the CI comes happens when the Nx uses the cached build. But when the dependent project is built locally or is also changed, then the whole PR builds fine. This is evident in this run which makes the content of the packages that is being depended upon, invalid. My hunch is that all |
c8dd89a to
ca07063
Compare
32ff1cc to
700559b
Compare
timdeschryver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @exequiel09 !
I've merged main into your branch to fix the build errors during the CI.
24486bd to
19378fb
Compare
Noice. The build is working fine now. Thank you @timdeschryver 🙏🏻 |



PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current behavior is that tests are running perfectly fine on
jest. This PR ensures that it runs smoothly onvitestwithout any errors.Closes #5020
What is the new behavior?
No new behavior. Just ensures to maintain parity when it runs using
vitestDoes this PR introduce a breaking change?
Other information