-
-
Notifications
You must be signed in to change notification settings - Fork 2k
refactor(entity): migrate unit tests to Vitest #5030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(entity): migrate unit tests to Vitest #5030
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
✅ Deploy Preview for ngrx-site-v19 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
89ddfe0 to
c39e131
Compare
c39e131 to
2235e75
Compare
|
Hey @timdeschryver thanks for fixing the build |
|
I guess I need to wait on this PR for the CI of #5035 to be fixed |
timdeschryver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added skip-nx-cache because the build was failing, I think it's fine to leave it like that.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
entity module has test using jest
Closes #
#5023
What is the new behavior?
now entity module will use vitest
Does this PR introduce a breaking change?
Other information