Skip to content

Conversation

@gabrielguerrero
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

entity module has test using jest

Closes #
#5023

What is the new behavior?

now entity module will use vitest

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 8378f17
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6932ba2a2c0c260008ed3a4f

@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 8378f17
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/6932ba2ab9130200082575c9
😎 Deploy Preview https://deploy-preview-5030--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gabrielguerrero gabrielguerrero changed the title chore(entity): Refactor entity module test to use vitest. Fix #5023 refactor(entity): Refactor entity module test to use vitest. Fix #5023 Nov 30, 2025
@gabrielguerrero gabrielguerrero force-pushed the chore/refactor-entity-module-test-to-vitest branch from 89ddfe0 to c39e131 Compare November 30, 2025 14:26
@gabrielguerrero gabrielguerrero force-pushed the chore/refactor-entity-module-test-to-vitest branch from c39e131 to 2235e75 Compare December 1, 2025 21:34
@gabrielguerrero
Copy link
Contributor Author

Hey @timdeschryver thanks for fixing the build

@markostanimirovic markostanimirovic changed the title refactor(entity): Refactor entity module test to use vitest. Fix #5023 refactor(entity): migrate unit tests to Vitest Dec 5, 2025
@exequiel09
Copy link
Contributor

I guess I need to wait on this PR for the CI of #5035 to be fixed

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added skip-nx-cache because the build was failing, I think it's fine to leave it like that.

@timdeschryver timdeschryver merged commit cbd1518 into ngrx:main Dec 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants