Skip to content

Conversation

@marinaglancy
Copy link
Contributor

@marinaglancy marinaglancy commented Mar 25, 2025

  1. E_STRICT does not have any meaning since PHP 8.0 and is officially deprecated in PHP 8.4 (Addresses Errors when running on PHP 8.4 #344)
  2. Add tests of moodle-plugin-ci on PHP 8.4
  3. Add option --scss-deprecations for behat (Addresses Add an option to run behat tests with --scss-deprecations #343)
  4. Bump PHP and postgres versions in Travis (not related to these issues but it was already failing)

E_STRICT does not have any meaning since PHP 8.0 and is officially deprecated in PHP 8.4
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (f31fea1) to head (73bb7d7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #346      +/-   ##
============================================
+ Coverage     88.26%   88.31%   +0.04%     
- Complexity      761      762       +1     
============================================
  Files            77       77              
  Lines          2335     2344       +9     
============================================
+ Hits           2061     2070       +9     
  Misses          274      274              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marinaglancy marinaglancy force-pushed the behatscssdeprecations branch from 0babbba to 6b8dd7e Compare March 25, 2025 10:55
@marinaglancy marinaglancy changed the title Add option --scss-depreactions for behat Add option --scss-deprecations for behat Mar 25, 2025
@marinaglancy marinaglancy changed the title Add option --scss-deprecations for behat Support PHP 8.4; Add option --scss-deprecations for behat Mar 25, 2025
@marinaglancy
Copy link
Contributor Author

lol I can't win with travis
Ubuntu focal (20.04) does not have PHP 8.4, Ubuntu jammy (22.04) does not have PHP 7.4

@marinaglancy marinaglancy force-pushed the behatscssdeprecations branch 2 times, most recently from f6d9889 to 959bebe Compare March 25, 2025 13:48
@marinaglancy
Copy link
Contributor Author

Note: I did not add 8.4 to travis. Feel free to create a separate issue. It is outside of the scope of the problems I was solving and also outside of my knowledge and I do not have time to find the solution at the moment.

@marinaglancy marinaglancy force-pushed the behatscssdeprecations branch from 959bebe to 73bb7d7 Compare March 26, 2025 14:02
@kabalin kabalin merged commit 6409652 into moodlehq:main Mar 26, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors when running on PHP 8.4 Add an option to run behat tests with --scss-deprecations

2 participants