Errors when running on PHP 8.4

[marinaglancy]

It looks like https://tracker.moodle.org/browse/MDL-80117 is close to being resolved, so I tried to run moodle-plugin-ci on my plugin with Moodle main branch (5.0) and PHP 8.4. I could not even execute moodle-plugin-ci install:

In MoodleProcess.php line 90:
                                                                               
  PHP error message was detected when running this command:                    
    '/usr/bin/php8.4' '-d' 'log_errors=1' '-d' 'error_log=null' '/home/runner  
  /work/moodle-tool_vault/moodle-tool_vault/moodle/admin/tool/phpunit/cli/uti  
  l.php' '--install'                                                           
  Moodle scripts should run without any PHP errors.                            
                                                                               
  Error Output                                                                 
  ============                                                                 
  PHP Deprecated:  Constant E_STRICT is deprecated in /home/runner/work/moodl  
  e-tool_vault/moodle-tool_vault/moodle/config.php on line 25                  

[marinaglancy]

If anybody wants a workaround - here is how you can change the GHA file to remove E_STRICT from the config.php file:

diff --git a/.github/workflows/gha.yml b/.github/workflows/gha.yml
index 45e6854..6b560e5 100644
--- a/.github/workflows/gha.yml
+++ b/.github/workflows/gha.yml
@@ -121,9 +121,14 @@ jobs:
 
       - name: Install moodle-plugin-ci
         run: |
-          moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1
+          moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1 --no-init
+          pushd moodle
+          sed -i 's|E_ALL \| E_STRICT|E_ALL|g' config.php
+          php admin/tool/phpunit/cli/util.php --install
+          php admin/tool/behat/cli/init.php --add-core-features-to-theme
+          popd
         env:
           DB: ${{ matrix.database }}
           MOODLE_BRANCH: ${{ matrix.moodle-branch }}
@@ -168,8 +173,18 @@ jobs:
         run: moodle-plugin-ci phpunit --fail-on-warning
 
       - name: Behat features
         id: behat
         if: ${{ !cancelled() }}
-        run: moodle-plugin-ci behat --profile chrome
+        run: moodle-plugin-ci behat --profile chrome --start-servers

       - name: Upload Behat Faildump