Skip to content

chore: upgrade oasdiff to the latest released version #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 31, 2025
Merged

chore: upgrade oasdiff to the latest released version #844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c60d4d
update oasdiff
andreaangiolillo Jul 28, 2025
8463d71
regenerate e2e tests files
andreaangiolillo Jul 28, 2025
e05a80e
Update go.mod
andreaangiolillo Jul 28, 2025
93d1185
Merge remote-tracking branch 'origin/main' into chore_lib_update
andreaangiolillo Jul 31, 2025
579d210
Update Makefile
andreaangiolillo Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/cli/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ deps: ## Download go module dependencies
devtools: ## Install dev tools
@echo "==> Installing dev tools..."
go install go.uber.org/mock/mockgen@latest
go install github.com/tufin/oasdiff@v1.10.29
go install github.com/oasdiff/oasdiff@v1.11.4
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(shell go env GOPATH)/bin $(GOLANGCI_VERSION)

.PHONY: setup
Expand Down
10 changes: 5 additions & 5 deletions tools/cli/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,17 @@ toolchain go1.24.0

require (
github.com/getkin/kin-openapi v0.132.0
github.com/oasdiff/oasdiff v1.11.4
github.com/spf13/afero v1.14.0
github.com/spf13/cobra v1.9.1
github.com/stretchr/testify v1.10.0
github.com/tufin/oasdiff v1.10.29
go.uber.org/mock v0.5.2
golang.org/x/text v0.24.0
gopkg.in/yaml.v3 v3.0.1
)

require (
cloud.google.com/go v0.118.3 // indirect
cloud.google.com/go v0.121.0 // indirect
github.com/TwiN/go-color v1.4.1 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/go-openapi/jsonpointer v0.21.0 // indirect
Expand All @@ -35,7 +36,6 @@ require (
github.com/tidwall/sjson v1.2.5 // indirect
github.com/wI2L/jsondiff v0.6.1 // indirect
github.com/yargevad/filepathx v1.0.0 // indirect
github.com/yuin/goldmark v1.7.8 // indirect
golang.org/x/exp v0.0.0-20250218142911-aa4b98e5adaa // indirect
golang.org/x/text v0.23.0 // indirect
github.com/yuin/goldmark v1.7.11 // indirect
golang.org/x/exp v0.0.0-20250305212735-054e65f0b394 // indirect
)
24 changes: 12 additions & 12 deletions tools/cli/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cloud.google.com/go v0.118.3 h1:jsypSnrE/w4mJysioGdMBg4MiW/hHx/sArFpaBWHdME=
cloud.google.com/go v0.118.3/go.mod h1:Lhs3YLnBlwJ4KA6nuObNMZ/fCbOQBPuWKPoE0Wa/9Vc=
cloud.google.com/go v0.121.0 h1:pgfwva8nGw7vivjZiRfrmglGWiCJBP+0OmDpenG/Fwg=
cloud.google.com/go v0.121.0/go.mod h1:rS7Kytwheu/y9buoDmu5EIpMMCI4Mb8ND4aeN4Vwj7Q=
github.com/TwiN/go-color v1.4.1 h1:mqG0P/KBgHKVqmtL5ye7K0/Gr4l6hTksPgTgMk3mUzc=
github.com/TwiN/go-color v1.4.1/go.mod h1:WcPf/jtiW95WBIsEeY1Lc/b8aaWoiqQpu5cf8WFxu+s=
github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
Expand All @@ -13,8 +13,8 @@ github.com/go-openapi/swag v0.23.0 h1:vsEVJDUo2hPJ2tu0/Xc+4noaxyEffXNIs3cOULZ+Gr
github.com/go-openapi/swag v0.23.0/go.mod h1:esZ8ITTYEsH1V2trKHjAN8Ai7xHb8RV+YSZ577vPjgQ=
github.com/go-test/deep v1.0.8 h1:TDsG77qcSprGbC6vTN8OuXp5g+J+b5Pcguhf7Zt61VM=
github.com/go-test/deep v1.0.8/go.mod h1:5C2ZWiW0ErCdrYzpqxLbTX7MG14M9iiw8DgHncVwcsE=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
github.com/josharian/intern v1.0.0 h1:vlS4z54oSdjm0bgjRigI+G1HpF+tI+9rE5LLzOg8HmY=
Expand All @@ -27,6 +27,8 @@ github.com/mailru/easyjson v0.9.0 h1:PrnmzHw7262yW8sTBwxi1PdJA3Iw/EKBa8psRf7d9a4
github.com/mailru/easyjson v0.9.0/go.mod h1:1+xMtQp2MRNVL/V1bOzuP3aP8VNwRW55fQUto+XFtTU=
github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 h1:RWengNIwukTxcDr9M+97sNutRR1RKhG96O6jWumTTnw=
github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826/go.mod h1:TaXosZuwdSHYgviHp1DAtfrULt5eUgsSMsZf+YrPgl8=
github.com/oasdiff/oasdiff v1.11.4 h1:FgThY78WNwOhWCLIhMk7AsKoHpVZZggRpKEGfd+IOIs=
github.com/oasdiff/oasdiff v1.11.4/go.mod h1:+bDxqI7wMl30OJ97hBfHR5loUsKCctk9UZOujHl8Gtk=
github.com/oasdiff/yaml v0.0.0-20250309154309-f31be36b4037 h1:G7ERwszslrBzRxj//JalHPu/3yz+De2J+4aLtSRlHiY=
github.com/oasdiff/yaml v0.0.0-20250309154309-f31be36b4037/go.mod h1:2bpvgLBZEtENV5scfDFEtB/5+1M4hkQhDQrccEJ/qGw=
github.com/oasdiff/yaml3 v0.0.0-20250309153720-d2182401db90 h1:bQx3WeLcUWy+RletIKwUIt4x3t8n2SxavmoclizMb8c=
Expand Down Expand Up @@ -56,22 +58,20 @@ github.com/tidwall/pretty v1.2.1 h1:qjsOFOWWQl+N3RsoF5/ssm1pHmJJwhjlSbZ51I6wMl4=
github.com/tidwall/pretty v1.2.1/go.mod h1:ITEVvHYasfjBbM0u2Pg8T2nJnzm8xPwvNhhsoaGGjNU=
github.com/tidwall/sjson v1.2.5 h1:kLy8mja+1c9jlljvWTlSazM7cKDRfJuR/bOJhcY5NcY=
github.com/tidwall/sjson v1.2.5/go.mod h1:Fvgq9kS/6ociJEDnK0Fk1cpYF4FIW6ZF7LAe+6jwd28=
github.com/tufin/oasdiff v1.10.29 h1:eWPoq0pnDIEKVX1jQ06JPqIVI9m6JUarfo2SCRJk86w=
github.com/tufin/oasdiff v1.10.29/go.mod h1:ATyMKGAf+viL7tGqn1nhOU8r6jb9240zPOQLvHQMULo=
github.com/ugorji/go/codec v1.2.11 h1:BMaWp1Bb6fHwEtbplGBGJ498wD+LKlNSl25MjdZY4dU=
github.com/ugorji/go/codec v1.2.11/go.mod h1:UNopzCgEMSXjBc6AOMqYvWC1ktqTAfzJZUZgYf6w6lg=
github.com/wI2L/jsondiff v0.6.1 h1:ISZb9oNWbP64LHnu4AUhsMF5W0FIj5Ok3Krip9Shqpw=
github.com/wI2L/jsondiff v0.6.1/go.mod h1:KAEIojdQq66oJiHhDyQez2x+sRit0vIzC9KeK0yizxM=
github.com/yargevad/filepathx v1.0.0 h1:SYcT+N3tYGi+NvazubCNlvgIPbzAk7i7y2dwg3I5FYc=
github.com/yargevad/filepathx v1.0.0/go.mod h1:BprfX/gpYNJHJfc35GjRRpVcwWXS89gGulUIU5tK3tA=
github.com/yuin/goldmark v1.7.8 h1:iERMLn0/QJeHFhxSt3p6PeN9mGnvIKSpG9YYorDMnic=
github.com/yuin/goldmark v1.7.8/go.mod h1:uzxRWxtg69N339t3louHJ7+O03ezfj6PlliRlaOzY1E=
github.com/yuin/goldmark v1.7.11 h1:ZCxLyDMtz0nT2HFfsYG8WZ47Trip2+JyLysKcMYE5bo=
github.com/yuin/goldmark v1.7.11/go.mod h1:ip/1k0VRfGynBgxOz0yCqHrbZXhcjxyuS66Brc7iBKg=
go.uber.org/mock v0.5.2 h1:LbtPTcP8A5k9WPXj54PPPbjcI4Y6lhyOZXn+VS7wNko=
go.uber.org/mock v0.5.2/go.mod h1:wLlUxC2vVTPTaE3UD51E0BGOAElKrILxhVSDYQLld5o=
golang.org/x/exp v0.0.0-20250218142911-aa4b98e5adaa h1:t2QcU6V556bFjYgu4L6C+6VrCPyJZ+eyRsABUPs1mz4=
golang.org/x/exp v0.0.0-20250218142911-aa4b98e5adaa/go.mod h1:BHOTPb3L19zxehTsLoJXVaTktb06DFgmdW6Wb9s8jqk=
golang.org/x/text v0.23.0 h1:D71I7dUrlY+VX0gQShAThNGHFxZ13dGLBHQLVl1mJlY=
golang.org/x/text v0.23.0/go.mod h1:/BLNzu4aZCJ1+kcD0DNRotWKage4q2rGVAg4o22unh4=
golang.org/x/exp v0.0.0-20250305212735-054e65f0b394 h1:nDVHiLt8aIbd/VzvPWN6kSOPE7+F/fNFDSXLVYkE/Iw=
golang.org/x/exp v0.0.0-20250305212735-054e65f0b394/go.mod h1:sIifuuw/Yco/y6yb6+bDNfyeQ/MdPUy/hKEMYQV17cM=
golang.org/x/text v0.24.0 h1:dd5Bzh4yt5KYA8f9CJHCP4FB4D51c2c6JvN37xJJkJ0=
golang.org/x/text v0.24.0/go.mod h1:L8rBsPeo2pSS+xqN0d5u2ikmjtmoJbDBT1b7nHvFCdU=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
Expand Down
6 changes: 3 additions & 3 deletions tools/cli/internal/changelog/changelog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ import (

"github.com/mongodb/openapi/tools/cli/internal/apiversion"
"github.com/mongodb/openapi/tools/cli/internal/openapi"
"github.com/tufin/oasdiff/checker"
"github.com/tufin/oasdiff/diff"
"github.com/tufin/oasdiff/load"
"github.com/oasdiff/oasdiff/checker"
"github.com/oasdiff/oasdiff/diff"
"github.com/oasdiff/oasdiff/load"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/changelog/manual_entry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"strings"

"github.com/mongodb/openapi/tools/cli/internal/changelog/outputfilter"
"github.com/tufin/oasdiff/checker"
"github.com/oasdiff/oasdiff/checker"
)

const manualChangelogEntry = "manual-changelog-entry"
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/changelog/merge.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
"sort"

"github.com/mongodb/openapi/tools/cli/internal/changelog/outputfilter"
"github.com/tufin/oasdiff/checker"
"github.com/oasdiff/oasdiff/checker"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/changelog/outputfilter/operationconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package outputfilter

import (
"github.com/getkin/kin-openapi/openapi3"
"github.com/tufin/oasdiff/load"
"github.com/oasdiff/oasdiff/load"
)

type OperationConfig struct {
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/changelog/outputfilter/operationconfig_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (

"github.com/getkin/kin-openapi/openapi3"
"github.com/mongodb/openapi/tools/cli/internal/openapi"
"github.com/oasdiff/oasdiff/load"
"github.com/stretchr/testify/require"
"github.com/tufin/oasdiff/load"
)

func TestOpenApiSpecMethods(t *testing.T) {
Expand Down
9 changes: 5 additions & 4 deletions tools/cli/internal/changelog/outputfilter/outputfilter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ package outputfilter
import (
"encoding/json"

"github.com/oasdiff/oasdiff/checker"
"github.com/oasdiff/oasdiff/formatters"
"github.com/oasdiff/oasdiff/load"
"github.com/spf13/afero"
"github.com/tufin/oasdiff/checker"
"github.com/tufin/oasdiff/formatters"
"github.com/tufin/oasdiff/load"
)

const lan = "en" // language for localized output
Expand Down Expand Up @@ -52,7 +52,8 @@ func NewChangelogEntries(checkers checker.Changes, specInfoPair *load.SpecInfoPa
return nil, err
}

bytes, err := formatter.RenderChangelog(checkers, formatters.RenderOpts{ColorMode: checker.ColorAuto}, specInfoPair)
bytes, err := formatter.RenderChangelog(checkers, formatters.RenderOpts{ColorMode: checker.ColorAuto},
specInfoPair.Base.Version, specInfoPair.Revision.Version)
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/changelog/sunset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
"time"

"github.com/mongodb/openapi/tools/cli/internal/changelog/outputfilter"
"github.com/tufin/oasdiff/checker"
"github.com/oasdiff/oasdiff/checker"
)

const endpointRemovedCode = "endpoint-removed"
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/cli/filter/filter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import (

"github.com/getkin/kin-openapi/openapi3"
"github.com/mongodb/openapi/tools/cli/internal/openapi"
"github.com/oasdiff/oasdiff/load"
"github.com/spf13/afero"
"github.com/stretchr/testify/require"
"github.com/tufin/oasdiff/load"
)

func TestSuccessfulFilter_Run(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/cli/split/split_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ import (

"github.com/getkin/kin-openapi/openapi3"
"github.com/mongodb/openapi/tools/cli/internal/openapi"
"github.com/oasdiff/oasdiff/load"
"github.com/spf13/afero"
"github.com/stretchr/testify/require"
"github.com/tufin/oasdiff/load"
)

func TestSuccessfulSplit_Run(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/openapi/errors/merge_conflict_error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
"encoding/json"
"fmt"

"github.com/tufin/oasdiff/diff"
"github.com/oasdiff/oasdiff/diff"
)

type ParamConflictError struct {
Expand Down
4 changes: 2 additions & 2 deletions tools/cli/internal/openapi/mock_oasdiff_result.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/cli/internal/openapi/mock_openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions tools/cli/internal/openapi/oasdiff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ import (

"github.com/getkin/kin-openapi/openapi3"
"github.com/mongodb/openapi/tools/cli/internal/openapi/errors"
"github.com/tufin/oasdiff/diff"
"github.com/tufin/oasdiff/load"
"github.com/oasdiff/oasdiff/diff"
"github.com/oasdiff/oasdiff/load"
)

type OasDiff struct {
Expand Down
6 changes: 3 additions & 3 deletions tools/cli/internal/openapi/oasdiff_result.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ package openapi
//go:generate mockgen -destination=../openapi/mock_oasdiff_result.go -package=openapi github.com/mongodb/openapi/tools/cli/internal/openapi DiffGetter
import (
"github.com/getkin/kin-openapi/openapi3"
"github.com/tufin/oasdiff/diff"
"github.com/tufin/oasdiff/flatten/allof"
"github.com/tufin/oasdiff/load"
"github.com/oasdiff/oasdiff/diff"
"github.com/oasdiff/oasdiff/flatten/allof"
"github.com/oasdiff/oasdiff/load"
)

// DiffGetter defines an interface for getting diffs.
Expand Down
4 changes: 2 additions & 2 deletions tools/cli/internal/openapi/oasdiff_result_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ import (
"testing"

"github.com/getkin/kin-openapi/openapi3"
"github.com/oasdiff/oasdiff/diff"
"github.com/oasdiff/oasdiff/load"
"github.com/stretchr/testify/require"
"github.com/tufin/oasdiff/diff"
"github.com/tufin/oasdiff/load"
gomock "go.uber.org/mock/gomock"
)

Expand Down
6 changes: 3 additions & 3 deletions tools/cli/internal/openapi/oasdiff_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ import (
"github.com/getkin/kin-openapi/openapi3"
"github.com/mongodb/openapi/tools/cli/internal/openapi/errors"
"github.com/mongodb/openapi/tools/cli/internal/pointer"
"github.com/oasdiff/oasdiff/diff"
"github.com/oasdiff/oasdiff/load"
"github.com/oasdiff/oasdiff/utils"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/tufin/oasdiff/diff"
"github.com/tufin/oasdiff/load"
"github.com/tufin/oasdiff/utils"
gomock "go.uber.org/mock/gomock"
)

Expand Down
4 changes: 2 additions & 2 deletions tools/cli/internal/openapi/openapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ import (
"log"

"github.com/getkin/kin-openapi/openapi3"
"github.com/tufin/oasdiff/diff"
"github.com/tufin/oasdiff/load"
"github.com/oasdiff/oasdiff/diff"
"github.com/oasdiff/oasdiff/load"
)

// Spec is a struct is a 1-to-1 copy of the Spec struct in the openapi3 package.
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/openapi/openapi3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"strings"

"github.com/getkin/kin-openapi/openapi3"
"github.com/tufin/oasdiff/load"
"github.com/oasdiff/oasdiff/load"
)

const publicPathPrefix = "api/atlas/v2"
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/openapi/sunset/sunset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
"sort"

"github.com/getkin/kin-openapi/openapi3"
"github.com/tufin/oasdiff/load"
"github.com/oasdiff/oasdiff/load"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion tools/cli/internal/openapi/sunset/sunset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"testing"

"github.com/getkin/kin-openapi/openapi3"
"github.com/oasdiff/oasdiff/load"
"github.com/stretchr/testify/assert"
"github.com/tufin/oasdiff/load"
)

func TestNewSunsetListFromSpec(t *testing.T) {
Expand Down
9 changes: 2 additions & 7 deletions ...s/cli/test/data/changelog/new-upcoming-version/output/2024-05-30_2025-09-22.upcoming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,8 @@
"tag": "OpenAPI",
"changes": [
{
"change": "removed the media type 'application/json' for the response with the status '200'",
"changeCode": "response-media-type-removed",
"backwardCompatible": false
},
{
"change": "added the media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response with the status '200'",
"changeCode": "response-media-type-added",
"change": "media type 'application/json' was changed to a more specific media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response status '200'",
"changeCode": "response-media-type-name-specialized",
"backwardCompatible": true
}
]
Expand Down
9 changes: 2 additions & 7 deletions ...s/cli/test/data/changelog/new-upcoming-version/output/2024-08-05_2025-09-22.upcoming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,8 @@
"tag": "OpenAPI",
"changes": [
{
"change": "removed the media type 'application/json' for the response with the status '200'",
"changeCode": "response-media-type-removed",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] can we check everywhere that we use these IDs? I think we might have something in breakinig changes/changelog to customize text/or breaking changes and probably need to update

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also exemptions for instance will stop working for the ids removed

Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] can we check everywhere that we use these IDs? I think we might have something in breakinig changes/changelog to customize text/or breaking changes and probably need to update

Good point 👍 I did a search of the ID in this repo and I did not find any reference to them

also exemptions for instance will stop working for the ids removed

My understanding is that we will need to update oasdiff in mms to have the same IDs. I checked and boths IDs are currently not in the exemptions file in mms

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool I did check them too and found but it looks like they are expired exemptions, hopefully no impact in this repo and just means more actions to be done when upgrading in MMS! for instance we'll probably need to update the scenarios test

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the oasdiff version in mms first and then I will merge this PR. Thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here: https://github.com/10gen/mms/pull/136112

"backwardCompatible": false
},
{
"change": "added the media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response with the status '200'",
"changeCode": "response-media-type-added",
"change": "media type 'application/json' was changed to a more specific media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response status '200'",
"changeCode": "response-media-type-name-specialized",
"backwardCompatible": true
}
]
Expand Down
9 changes: 2 additions & 7 deletions ...s/cli/test/data/changelog/new-upcoming-version/output/2024-10-23_2025-09-22.upcoming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,8 @@
"tag": "OpenAPI",
"changes": [
{
"change": "removed the media type 'application/json' for the response with the status '200'",
"changeCode": "response-media-type-removed",
"backwardCompatible": false
},
{
"change": "added the media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response with the status '200'",
"changeCode": "response-media-type-added",
"change": "media type 'application/json' was changed to a more specific media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response status '200'",
"changeCode": "response-media-type-name-specialized",
"backwardCompatible": true
}
]
Expand Down
9 changes: 2 additions & 7 deletions ...s/cli/test/data/changelog/new-upcoming-version/output/2024-11-13_2025-09-22.upcoming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,8 @@
"tag": "OpenAPI",
"changes": [
{
"change": "removed the media type 'application/json' for the response with the status '200'",
"changeCode": "response-media-type-removed",
"backwardCompatible": false
},
{
"change": "added the media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response with the status '200'",
"changeCode": "response-media-type-added",
"change": "media type 'application/json' was changed to a more specific media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response status '200'",
"changeCode": "response-media-type-name-specialized",
"backwardCompatible": true
}
]
Expand Down
9 changes: 2 additions & 7 deletions ...s/cli/test/data/changelog/new-upcoming-version/output/2025-02-19_2025-09-22.upcoming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,8 @@
"tag": "OpenAPI",
"changes": [
{
"change": "removed the media type 'application/json' for the response with the status '200'",
"changeCode": "response-media-type-removed",
"backwardCompatible": false
},
{
"change": "added the media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response with the status '200'",
"changeCode": "response-media-type-added",
"change": "media type 'application/json' was changed to a more specific media type 'application/vnd.atlas.2025-09-22.upcoming+json' for the response status '200'",
"changeCode": "response-media-type-name-specialized",
"backwardCompatible": true
}
]
Expand Down
Loading
Loading