-
Notifications
You must be signed in to change notification settings - Fork 14
chore: upgrade oasdiff to the latest released version #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -6,13 +6,8 @@ | |||
"tag": "OpenAPI", | |||
"changes": [ | |||
{ | |||
"change": "removed the media type 'application/json' for the response with the status '200'", | |||
"changeCode": "response-media-type-removed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] can we check everywhere that we use these IDs? I think we might have something in breakinig changes/changelog to customize text/or breaking changes and probably need to update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also exemptions for instance will stop working for the ids removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] can we check everywhere that we use these IDs? I think we might have something in breakinig changes/changelog to customize text/or breaking changes and probably need to update
Good point 👍 I did a search of the ID in this repo and I did not find any reference to them
also exemptions for instance will stop working for the ids removed
My understanding is that we will need to update oasdiff in mms to have the same IDs. I checked and boths IDs are currently not in the exemptions file in mms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool I did check them too and found but it looks like they are expired exemptions, hopefully no impact in this repo and just means more actions to be done when upgrading in MMS! for instance we'll probably need to update the scenarios test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the oasdiff version in mms first and then I will merge this PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes
This PR updates oasdiff to the latest release.
Note that oasdiff moved the repo from tufin to oasdiff so the PR contains imports renaming.