Additional fixed signatures test in the wallet#1931
Merged
Conversation
OBorce
approved these changes
Jun 29, 2025
ImplOfAnImpl
force-pushed
the
wallet_additional_fixed_sig_tests
branch
from
5539c2e to
bf301bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed a bug in the trezor signer where htlc multisig signature wasn't wrapped into
AuthorizedHashedTimelockContractSpend::Multisig(the fix is already tested by the added fixed signature test, so no additional test is needed)