Allow ProduceBlockFromStake utxos#9
Merged
ImplOfAnImpl merged 1 commit intoJul 2, 2025
Conversation
OBorce
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
_sanitize_tx_outputraises an exception onProduceBlockFromStaketx outputs, on the assumption that such outputs are useless, but the function is called for UTXOs too, preventing us from signingProduceBlockFromStakeinputs.In general, I don't see why we should prohibit
ProduceBlockFromStakeeven if it's in the outputs, so I've just removed theraisestatement.P.S. the newly added test in mintlayer/mintlayer-core#1931 fails without this fix.