Skip to content

Add --noexcept bindgen option for WinRT methods#4366

Merged
kennykerr merged 5 commits intomasterfrom
copilot/add-noexcept-bindgen-option
May 2, 2026
Merged

Add --noexcept bindgen option for WinRT methods#4366
kennykerr merged 5 commits intomasterfrom
copilot/add-noexcept-bindgen-option

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 1, 2026

  • Add bindgen fixture for --noexcept option
  • Use assert! in generated noexcept call-sites when noexcept is forced via --noexcept flag (no NoExceptionAttribute on the method)
  • Keep debug_assert! when the method genuinely carries NoExceptionAttribute
  • Update fixture expected.rs to reflect assert! for the flag-driven case
  • Update Bindgen::noexcept() doc comment to document the asymmetric behavior
  • Verify existing generated bindings (UIAutomation etc., which use the attribute) remain on debug_assert!
  • Run bindgen fixture tests (177 passed)

Copilot AI and others added 2 commits May 1, 2026 18:21
Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/2d500f8f-1f89-4c94-9e9f-b4e72b657f80

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
…ceptionAttribute is present

Agent-Logs-Url: https://github.com/microsoft/windows-rs/sessions/d94b9cd4-0e87-471c-af6a-5b12ecc1e056

Co-authored-by: kennykerr <9845234+kennykerr@users.noreply.github.com>
@kennykerr kennykerr merged commit 3786a76 into master May 2, 2026
30 checks passed
@kennykerr kennykerr deleted the copilot/add-noexcept-bindgen-option branch May 2, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants