🌱 Add prep fkas directory -step for fkas-image-build action #2826
Conversation
metal3-io-bot
added
the
size/S
peppi-lotta
force-pushed
the
peppi-lotta/add-repo-prep-to-fkas-build-action
branch
from
d081b8c to
6ea69f0
Compare
peppi-lotta
force-pushed
the
peppi-lotta/add-repo-prep-to-fkas-build-action
branch
from
6ea69f0 to
05391ff
Compare
peppi-lotta
changed the title
peppi-lotta
force-pushed
the
peppi-lotta/add-repo-prep-to-fkas-build-action
branch
from
05391ff to
d5992a5
Compare
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
Can't test this locally as it really wants to find your branch and not just use whats the the local repo. Not a fault of this PR though.
One more nit.
Signed-off-by: peppi-lotta <[email protected]>
peppi-lotta
force-pushed
the
peppi-lotta/add-repo-prep-to-fkas-build-action
branch
from
d5992a5 to
87a5d79
Compare
tuminoid
left a comment
tuminoid
left a comment
There was a problem hiding this comment.
/cc @kashifest @lentzi90 @adilGhaffarDev
PTAL
LGTM, but testing is bit difficult.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adilGhaffarDev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@adilGhaffarDev: Overrode contexts on behalf of adilGhaffarDev: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| mkdir -p hack/fake-apiserver/capm3 | ||
| cp -r api/ hack/fake-apiserver/capm3 | ||
| cd hack/fake-apiserver | ||
| go mod edit -replace=github.com/metal3-io/cluster-api-provider-metal3=./capm3 |
There was a problem hiding this comment.
this is smart, didn't think about this solution when I was looking into it.
metal3-io-bot
deleted the
peppi-lotta/add-repo-prep-to-fkas-build-action
branch
5 participants
What this PR does / why we need it: Prep fkas directory for build in github action
I've been able to run this the added steps successfully locally and build steps should work as always. I don't know if there is any way to run this workflow before merging. These steps are needed because in this pr, #2814, I switch the fkas builds are using from static to main.