🌱 Allow downloading artifacts to allow pre-preparing directories for image-building #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
tuminoid
reviewed
Oct 8, 2025
…age-building Signed-off-by: peppi-lotta <[email protected]>
peppi-lotta
force-pushed
the
peppi-lotta/download-artifacts-to-allow-preparing-directories-for-image-building
branch
from
c8405a8 to
c59596b
Compare
Member
|
/override metal3-ubuntu-e2e-integration-test-main |
Collaborator
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
metal3-io-bot
deleted the
peppi-lotta/download-artifacts-to-allow-preparing-directories-for-image-building
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: A docker image building requires that all the element needed for building are in the same directory or sub directory where the
Dockerfileis located. This is why I created a PR that prepares FKAS for image building by moving the required CAPM3 directory into the Fake-apiserver directory before building.Because we are using a reusable workflow for image building, the directory prep has to be done in a separate job. It seems changes are not retained across jobs even when they are run in the same workflow. I'm suggesting to use the upload-archive and download-archive actions to pass the pre prepared FKAS folder from one job to another.
Related PR in CAPM3 can be found here: metal3-io/cluster-api-provider-metal3#2846