docs: remove derivable/copied content, convert external copies to pointers, fix upstream drift - #3387
Conversation
…x upstream drift Repo-wide tri-skill audit (docs-hygiene:audit-derivability, discipline:recheck-against-upstream-deep, discipline:point-dont-copy) over 1270 tracked markdown files. Applied set: - fable-field-guide-audit: delete 14 absorbed working files (S2-S6, S8-S14, audit-brief, coverage-reconcile) plus raw-capture.txt; keep S1/S7 (cited by surviving reviews); convert source-article.md from a verbatim external-article copy to a pointer stub (URL + S1-S14 legend) - point-dont-copy conversions: work-items gh-auth-status rationale (2 files -> providers.md) and cadence table (recheck.md -> add.md); session-flow retro hook-events table -> official hooks doc; claude-ops read-routing retention table -> operator-setup-retention.md; testing non-ui MCP initialize shapes -> MCP spec lifecycle page; shadowed-skill-renames grammar bullets -> PLUGIN-PHILOSOPHY Naming - remove unsourced 27K/114K/4x token figure (playwright README+SKILL, testing run-e2e SKILL+e2e.md), keeping the qualitative claim - upstream-conformance fixes verified against current docs: Monitor allow rules added to permission-rule-hygiene dropped-rules quote (v2.1.236); audit-install-state surfaces table gains uploads/, feedback/drafts/, usage-data/ and image-cache's distinct sweep rule; doctor-handoff DISABLE_DOCTOR_COMMAND re-hedged (doc row flip-flops); discipline setup fork-mode default-on framing (>= v2.1.232); dotnet --project gotcha scoped to opt-in MTP runner; git 2.56 worktree includeIf hedged as unreleased Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018a2V2EdWMNPTx411FGdbes
Fresh-context diff verification caught two surviving lines in dispositions.md and disposition-review.md still naming the deleted working file; both now describe the retired completeness check without the filename. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018a2V2EdWMNPTx411FGdbes
…erivability-audit-qvqsiu
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d5016c011
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…r-suppression status The MCP handshake pointer claimed "current" while linking the immutable 2025-06-18 lifecycle URL; it now names the pinned revision, points at /specification/latest, and notes revisions after 2025-11-25 drop the initialize handshake. doctor-handoff's item-3 title and the suppression-channels paragraph now consistently treat DISABLE_DOCTOR_COMMAND as unconfirmed, matching the re-check note. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018a2V2EdWMNPTx411FGdbes
|
Claude finished @kyle-sexton's task in 2m 40s —— View job Code Review
Skip gate: does not apply — PR is open, not draft, and the change has real review surface (upstream-drift corrections, deletions, pointer conversions across 35 files). Scope reviewed: full Prior Codex findings — both resolved in the latest commitThe two open review comments from
I re-read both sections end-to-end and didn't find any remaining internal contradiction (title, body, and the two later restatements all agree now). Independent findingsNone. I checked, in addition to the above:
No correctness or maintainability issues found beyond what's already fixed. |
|
Claude finished @kyle-sexton's task in 48s —— View job CI Security Review
Skip gate: no security-relevant surface. This PR's diff ( Per this lane's skip gate, that means no deep review is warranted:
Confirmed no security issues in scope for this lane (logic flaws, auth/access-control gaps, injection surfaces, secret/token handling, or dangerous GitHub Actions patterns) — there's no code or workflow to carry them. Two prior Codex findings on this PR (MCP spec pinning in |
|
Last security-reviewed head: |
The changelog-parity gate requires a manifest bump and a new CHANGELOG release entry whenever shipped plugin files change. Patch-bumps claude-config, claude-ops, discipline, playwright, session-flow, source-control, testing, toolchain, and work-items with entries describing the derivability/point-dont-copy audit treatments. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018a2V2EdWMNPTx411FGdbes
|
Claude has reviewed this PR 2 times. The lane skips further automatic reviews after 5; deleting this comment resets the count. |
|
Claude finished @kyle-sexton's task in 2m 17s —— View job Code review —
|
|
Claude finished @kyle-sexton's task in 39s —— View job CI Security Review
Skip gate: no security-relevant surface. Re-checked the full diff at HEAD
No
No security findings in scope for this lane (logic flaws, auth/access-control gaps, injection surfaces, secret/token handling, dangerous GitHub Actions patterns) — there's no code or workflow to carry them. The two prior Codex findings (MCP spec revision pinning in |
No linked issue
Summary
Repo-wide tri-skill audit (
/docs-hygiene:audit-derivability,/discipline:recheck-against-upstream-deep,/discipline:point-dont-copy) over all 1,270 tracked markdown files, applying only the high-confidence, verification-backed subset: derivable working files whose conclusions were absorbed elsewhere are deleted, content copied from external sources is replaced with pointers to the living owners, and stale upstream restatements are corrected against docs fetched this session.Fix
docs/topics/fable-field-guide-audit/source-article.md(verbatim copy of the Anthropic "Field guide to Claude Fable 5" blog post) is now a pointer stub keeping the URL and the S1–S14 legend; itsraw-capture.txttwin is deleted. A ~25-row hook-events table lifted from the official docs (session-flowretro catalog) now links to code.claude.com/docs/en/hooks; copied MCPinitializeJSON shapes (testingrun-e2e) now link to the MCP spec lifecycle page.fable-field-guide-auditfindings S2–S6/S8–S14,audit-brief.md,coverage-reconcile.md— a fresh-context verifier confirmed every conclusion survives indispositions.md/repair-ledger.md. S1/S7 kept (cited as evidence by surviving reviews); the two surviving prose mentions of the removed file were reworded.providers.md), cadence table (→add.md, which the repo already declares as its SSOT), claude-ops retention table (→operator-setup-retention.md), shadowed-skill-renames grammar bullets (→PLUGIN-PHILOSOPHY.md§ Naming, verified superset).uploads/,feedback/drafts/,usage-data/and image-cache's distinct sweep rule;DISABLE_DOCTOR_COMMANDre-hedged as unconfirmed (docs row has flip-flopped); fork-mode default-on framing (≥ v2.1.232); .NET 10--projectgotcha scoped to the opt-in MTP runner; git 2.56worktree:includeIf marked unreleased.Deliberate multi-copies (
artifact-protocol.md×5 plugins, #2698 inline boilerplate) were recognized and left intact. Larger judgment calls (Pattison corpus posture, the userConfig-defaults upstream change, #1419 topic graduation) are report-only, not in this diff.Verification
#naming,#cadence-duration-table,#retention-knobs,providers.md); lychee fragment rule respected.fable-field-guide-auditslug's directory survives).Related
Refs #1419 (docs/topics graduate-then-prune debt — surfaced by the audit, not addressed here). Refs #2698 (inline-boilerplate adjudication honored). Report-only findings, including four independent hits on the upstream userConfig-defaults change (
CLAUDE_PLUGIN_OPTION_<KEY>now exported), were delivered to the repo owner outside this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_018a2V2EdWMNPTx411FGdbes
Generated by Claude Code