-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[DNM] Remove ListIterator
#10880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erwanMarmelab
wants to merge
28
commits into
master
Choose a base branch
from
remox-list-iterator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DNM] Remove ListIterator
#10880
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
d333485
remove `ListIterator.tsx` and `ListIterator.md`
erwanMarmelab 8ed2845
remove `ListIterator.spect.tsx` and `ListIterator.stories.tsx`
erwanMarmelab 62a8adf
remove `ListIterator` usage of `SingleFieldList`
erwanMarmelab 339674c
remove ListIterator export
erwanMarmelab f7d0660
remove `ListIterator` usage of `SimpleList`
erwanMarmelab a29816e
Adapt the SimpleList stories
erwanMarmelab 25644fa
Adapt the ReferenceManyFieldBase story
erwanMarmelab 7970990
adapt docs
erwanMarmelab 364ce4c
Remove duplicated Stack
erwanMarmelab 29f57f4
fix doc
erwanMarmelab efd1237
Update packages/ra-ui-materialui/src/list/SimpleList/SimpleList.tsx
erwanMarmelab 835fd62
fix index error
erwanMarmelab a03318f
fix asynchrone issue in tests
erwanMarmelab b7098fd
Merge branch 'remox-list-iterator' of github.com:marmelab/react-admin…
erwanMarmelab 1b5b7fb
code review -> fix SimpleList standalone usage with the data prop
erwanMarmelab ed3c53d
code review -> use ListBase render prop
erwanMarmelab da27cc4
Add a ListIterator alias for WithListcontext
erwanMarmelab 7cd9254
Update WithListContext to accept optional empty, loading and error co…
erwanMarmelab 38054e3
fix BC
erwanMarmelab 691a075
remove useless imports
erwanMarmelab 5fd2476
use new props in the doc
erwanMarmelab f847200
add WithListContext tests
erwanMarmelab 62abeea
Document new WithListContext keys
erwanMarmelab 811ccbd
Improve new key descriptions
erwanMarmelab 55ee73b
Change WithListContext for standalone usage, add RecordsIterator.
Madeorsk c44e43a
Fix WithListContext props order.
Madeorsk 4b20bec
Document standalone usage of WithListContext and fix error element pr…
Madeorsk 5c5f55a
Improve ReferenceFieldBase doc.
Madeorsk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code isn't better than the previous one. It underlines the fact that RecordsIterator should probably return
null
while loading, without any warning.