[DNM] Remove ListIterator
#10880
Open
[DNM] Remove ListIterator
#10880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madeorsk
requested changes
Aug 5, 2025
packages/ra-core/src/controller/field/ReferenceManyFieldBase.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/SimpleList/SimpleList.stories.tsx
Outdated
Show resolved
Hide resolved
Madeorsk
requested changes
Aug 5, 2025
Co-authored-by: Madeorsk <[email protected]>
Madeorsk
force-pushed
the
remox-list-iterator
branch
from
280adcc to
4b20bec
Compare
fzaninotto
requested changes
Aug 12, 2025
| </ReferenceArrayFieldBase> | ||
| </ListIterator> | ||
| </ListBase> | ||
| <ListBase |
There was a problem hiding this comment.
This code isn't better than the previous one. It underlines the fact that RecordsIterator should probably return null while loading, without any warning.
|
|
||
| export interface WithListContextProps<RecordType extends RaRecord> { | ||
| if (isPending === true && loading) { |
There was a problem hiding this comment.
loading=null is a valid ReactNode and should be taken into account. I thing you should change the test to be as in https://github.com/marmelab/react-admin/pull/10864/files#diff-cdac9daf5ac7f12fe651a4357b777c27564f7372b0387256dd630f0a9d07c479
| hasTertiaryText={!!tertiaryText} | ||
| /> | ||
| } | ||
| empty={empty ?? <></>} |
| render={({ data }) => ( | ||
| <Root className={className} {...sanitizeListRestProps(rest)}> | ||
| <RecordsIterator | ||
| data={data} |
There was a problem hiding this comment.
I don't know why you need data here
| {...sanitizeListRestProps(rest)} | ||
| > | ||
| <RecordsIterator | ||
| data={data} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ListIteratorhas a drawback:empty,loadinganderrorstates appear inside the wrapper (often a<ul>). It makes it unusable in most cases.Solution
<SingleFieldList>and<SimpleList>to not use itWithListContextto accept optionalempty,loadinganderrorcomponentsAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature[ ] The PR includes unit tests (if not possible, describe why)