Skip to content

Conversation

@HarelM
Copy link
Collaborator

@HarelM HarelM commented Nov 20, 2025

Launch Checklist

The problem is that the editor at the end of the layer editor view is forcing some scrolling due to a different bug that was solved.

The previous fix was in oder to solve issues in the code editor which has all the style in it, and a search-and-replace operation is used to change the content, so there was a need to introduce the previous fix.
The current solution is to scroll the view only if the search and replace is in focus, which is a more specific fix to the previous issue, and I think this fix is brittle due to how it is implemented.
Having said that, I'm not sure I have a better solution to this issue.

  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.69%. Comparing base (7a93d59) to head (6afb713).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/components/InputJson.tsx 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
- Coverage   71.11%   69.69%   -1.42%     
==========================================
  Files         102      102              
  Lines        6955     6362     -593     
  Branches     2118     1848     -270     
==========================================
- Hits         4946     4434     -512     
+ Misses       2006     1925      -81     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layer drawer scrolls/jumps around when editing properties

3 participants