-
Notifications
You must be signed in to change notification settings - Fork 57
feat: migrate adobe kit to monorepo #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickolas-dimitrakas
wants to merge
7
commits into
workstation/3.0-Release
Choose a base branch
from
feat/migrate-adobe
base: workstation/3.0-Release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
68936dd
feat: migrate adobe kit to monorepo
nickolas-dimitrakas a2fed62
fix(ci): exclude adobe vendor files from prettier and kit tests from …
nickolas-dimitrakas f4ad4bc
fix(ci): create dist directories before build in adobe kit
nickolas-dimitrakas e5aee72
fix(ci): add missing suffix to adobe server kit test config
nickolas-dimitrakas 0be3b0b
refactor(jest): narrow testPathIgnorePatterns to kits/adobe only
nickolas-dimitrakas b74eb0c
refactor(jest): remove redundant node_modules from testPathIgnorePatt…
nickolas-dimitrakas f3c49f9
refactor(adobe): align prettier config with root, add eslintrc root flag
nickolas-dimitrakas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,5 @@ snippet.min.js | |
| snippet.rokt.min.js | ||
| test/lib | ||
| mparticle.js | ||
| test/ | ||
| test/ | ||
| kits/adobe/AdobeSDKs/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "root": true, | ||
| "env": { | ||
| "node": true | ||
| }, | ||
| "parserOptions": { | ||
| "ecmaVersion": 6, | ||
| "sourceType": "module", | ||
| "ecmaFeatures": { | ||
| "modules": true | ||
| } | ||
| }, | ||
| "globals": { | ||
| "window": true, | ||
| "document": true, | ||
| "Visitor": true, | ||
| "AppMeasurement": true, | ||
| "ADB": true | ||
| }, | ||
| "extends": "eslint:recommended", | ||
| "rules": { | ||
| "linebreak-style": ["error", "unix"], | ||
| "quotes": ["error", "single"], | ||
| "semi": ["error", "always"], | ||
| "no-unneeded-ternary": [ | ||
| "error", | ||
| { | ||
| "defaultAssignment": false | ||
| } | ||
| ], | ||
| "comma-dangle": ["error", "never"], | ||
| "curly": ["error", "multi-line"], | ||
| "comma-spacing": [ | ||
| "error", | ||
| { | ||
| "before": false, | ||
| "after": true | ||
| } | ||
| ], | ||
| "quote-props": [ | ||
| "error", | ||
| "as-needed", | ||
| { | ||
| "keywords": false, | ||
| "unnecessary": true, | ||
| "numbers": false | ||
| } | ||
| ], | ||
| "no-multi-spaces": "error", | ||
| "no-prototype-builtins": 0, | ||
| "no-implicit-globals": "error" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node | ||
| # For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions | ||
|
|
||
| name: Pull Requests | ||
|
|
||
| on: | ||
| pull_request | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm ci | ||
| - run: npm run build --if-present | ||
| - run: npm test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| node_modules/ |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| node_modules | ||
| test/test-bundle.js | ||
| test/end-to-end-testapp/compilation.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| language: node_js | ||
| node_js: | ||
| - "7" | ||
| dist: trusty | ||
| sudo: required | ||
| addons: | ||
| chrome: stable | ||
| firefox: latest | ||
| cache: | ||
| directories: | ||
| - node_modules | ||
| script: | ||
| - npm install | ||
| - npm run testKarma -- --single-run=true --browsers=ChromeHeadless,FirefoxHeadless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Adobe Heartbeat Mapping | ||
|
|
||
| This Adobe Heartbeat mapping is imported by both the Adobe Client and Adobe Server integrations located in the `packages/` directory. It is not a separate integration, but instead contains code to map an mParticle Media event that is sent to the Client or Server integrations. | ||
|
|
||
| ## License | ||
|
|
||
| Copyright 2019 mParticle, Inc. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexs-mparticle @rmi22186 @jaissica12 @khushi1033 Will have a follow up PR in cleanup to align all the formatting configs and resolve the differences to align with the root config.