feat: migrate adobe kit to monorepo#1207
Open
nickolas-dimitrakas wants to merge 7 commits intoworkstation/3.0-Releasefrom
Open
feat: migrate adobe kit to monorepo#1207nickolas-dimitrakas wants to merge 7 commits intoworkstation/3.0-Releasefrom
nickolas-dimitrakas wants to merge 7 commits intoworkstation/3.0-Releasefrom
Conversation
nickolas-dimitrakas
force-pushed
the
feat/migrate-adobe
branch
from
baf4e66 to
a91c8fa
Compare
Migrates mparticle-javascript-integration-adobe into the web SDK monorepo under kits/adobe/. The Adobe kit uses a repo-level build and test orchestration — the root rollup.config.js concatenates AdobeSDKs vendor files with each package's source before bundling, and tests run from the root using Jest with MODULE env vars. The full repo structure is preserved under kits/adobe/ to keep this working correctly. Structure: - kits/adobe/packages/AdobeClient (@mparticle/web-adobe-client-kit v2.1.3) - kits/adobe/packages/AdobeServer (@mparticle/web-adobe-server-kit v2.1.2) - kits/adobe/HeartbeatKit - kits/adobe/AdobeSDKs (VisitorAPI.js, AppMeasurement.js) - kits/adobe/test (Jest tests for client + server) - Updated package.json repository field to point to monorepo - Added kits/adobe to kits/matrix.json for CI coverage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nickolas-dimitrakas
force-pushed
the
feat/migrate-adobe
branch
from
a91c8fa to
68936dd
Compare
…jest - Add kits/adobe/AdobeSDKs/ and babel.config.js to .prettierignore to exclude third-party vendor files from formatting checks - Add testPathIgnorePatterns to jest.config.js to prevent root jest runner from picking up kit test files (kits use karma, not jest) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fresh git checkouts don't include empty dist/ directories (git doesn't track empty directories and .gitignore excludes dist/). Add mkdir -p to the build:client:* and build:server:* scripts so the build succeeds in a clean CI environment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Server kit registers with suffix 'Server' creating key 'Adobe-Server' in mParticle's forwarder constructors map. Without suffix: 'Server' in the test kitConfig, configureUIEnabledKit cannot match the constructor and initForwarder is never called, causing all integration tests to fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nickolas-dimitrakas
requested review from
alexs-mparticle,
jaissica12,
khushi1033 and
rmi22186
Previously excluded all kits/ which was overly broad. Only the Adobe kit uses Jest (with test.js / server.test.js filenames that match Jest's default testMatch). Other kits use Karma and name their files tests.js (plural), so they don't need an explicit exclusion. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…erns Jest ignores node_modules by default; the explicit entry was unnecessary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove kits/adobe/.prettierrc so Adobe inherits root prettier settings. Only difference was trailingComma: "none" vs root's "es5"; Adobe source files reformatted accordingly (trailing commas added, no logic changes). - Update .prettierignore: remove kits/adobe/babel.config.js (no longer needed once trailing comma conflict is resolved); keep AdobeSDKs/ vendor exclusion. - Add "root": true to kits/adobe/.eslintrc to prevent ESLint from walking up to root config when run from within the kit directory. Part of ongoing effort to consolidate all configs at the repo root. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Comment on lines
1
to
4
| { | ||
| "root": true, | ||
| "env": { | ||
| "node": true |
Contributor
Author
There was a problem hiding this comment.
@alexs-mparticle @rmi22186 @jaissica12 @khushi1033 Will have a follow up PR in cleanup to align all the formatting configs and resolve the differences to align with the root config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
What Changed
Checklist
Reference Issue (For employees only. Ignore if you are an outside contributor)