Skip to content

Fix VAD Path for Custom VAD loading #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix VAD Path for Custom VAD loading #657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bc12cb
Added changes
Jan 4, 2024
2760815
Added changes
Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions whisperx/asr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def load_model(whisper_arch,
compute_type="float16",
asr_options=None,
language : Optional[str] = None,
vad_model=None,
vad_model_fp=None,
vad_options=None,
model : Optional[WhisperModel] = None,
task="transcribe",
Expand All @@ -275,6 +275,7 @@ def load_model(whisper_arch,
compute_type: str - The compute type to use for the model.
options: dict - A dictionary of options to use for the model.
language: str - The language of the model. (use English for now)
vad_model_fp: str - File path to the VAD model to use
model: Optional[WhisperModel] - The WhisperModel instance to use.
download_root: Optional[str] - The root directory to download the model to.
threads: int - The number of cpu threads to use per worker, e.g. will be multiplied by num workers.
Expand Down Expand Up @@ -338,8 +339,8 @@ def load_model(whisper_arch,
if vad_options is not None:
default_vad_options.update(vad_options)

if vad_model is not None:
vad_model = vad_model
if vad_model_fp is not None:
vad_model = load_vad_model(torch.device(device), use_auth_token=None, **default_vad_options, model_fp=vad_model_fp)
else:
vad_model = load_vad_model(torch.device(device), use_auth_token=None, **default_vad_options)

Expand Down