Skip to content

Fix VAD Path for Custom VAD loading #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix VAD Path for Custom VAD loading #657

wants to merge 2 commits into from

Conversation

@Swami-Abhinav
Copy link

@Swami-Abhinav Swami-Abhinav commented Jan 4, 2024

Fix VAD Path for Custom VAD loading

@Swami-Abhinav Swami-Abhinav force-pushed the fix-custom-vad-file-path branch from a93ca91 to 2760815 Compare January 4, 2024 14:34
@gillens gillens mentioned this pull request Feb 21, 2024
Closed
darkmirage added a commit to SesameAILabs/whisperX that referenced this pull request Oct 25, 2024
@darkmirage
Fix VAD model loading PR m-bain#657
1834ff2
3manifold
3manifold suggested changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@3manifold 3manifold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vad_model variable is used to manually assign a vad method that inherits from Vad class (see def load_model in whisperx/asr.py). Thus, there is no fix that makes sense in this case.

One can pass model_fp in Pyannote ctor if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@3manifold 3manifold 3manifold requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Swami-Abhinav @3manifold